You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "joel-hamill (via GitHub)" <gi...@apache.org> on 2025/11/12 22:03:13 UTC
[PR] MINOR: make description more clear for group.protocol [kafka]
joel-hamill opened a new pull request, #20870:
URL: https://github.com/apache/kafka/pull/20870
Update the description for the group.protocol to correct grammar issues and make description more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: make description more clear for group.protocol [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on code in PR #20870:
URL: https://github.com/apache/kafka/pull/20870#discussion_r2520027611
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -112,9 +112,8 @@ public class ConsumerConfig extends AbstractConfig {
*/
public static final String GROUP_PROTOCOL_CONFIG = "group.protocol";
public static final String DEFAULT_GROUP_PROTOCOL = GroupProtocol.CLASSIC.name().toLowerCase(Locale.ROOT);
- public static final String GROUP_PROTOCOL_DOC = "The group protocol consumer should use. We currently " +
- "support \"classic\" or \"consumer\". If \"consumer\" is specified, then the consumer group protocol will be " +
- "used. Otherwise, the classic group protocol will be used.";
+ public static final String GROUP_PROTOCOL_DOC = "The group protocol that the consumer uses. The " +
+ "supported values are <code>classic<\code> or <code>consumer<\code>. The default value is <code>classic<\code>.";
Review Comment:
Build failure because it doesn't like `<\code>`. Please replace with `</code>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: make description more clear for group.protocol [kafka]
Posted by "joel-hamill (via GitHub)" <gi...@apache.org>.
joel-hamill commented on code in PR #20870:
URL: https://github.com/apache/kafka/pull/20870#discussion_r2520096203
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##########
@@ -112,9 +112,8 @@ public class ConsumerConfig extends AbstractConfig {
*/
public static final String GROUP_PROTOCOL_CONFIG = "group.protocol";
public static final String DEFAULT_GROUP_PROTOCOL = GroupProtocol.CLASSIC.name().toLowerCase(Locale.ROOT);
- public static final String GROUP_PROTOCOL_DOC = "The group protocol consumer should use. We currently " +
- "support \"classic\" or \"consumer\". If \"consumer\" is specified, then the consumer group protocol will be " +
- "used. Otherwise, the classic group protocol will be used.";
+ public static final String GROUP_PROTOCOL_DOC = "The group protocol that the consumer uses. The " +
+ "supported values are <code>classic<\code> or <code>consumer<\code>. The default value is <code>classic<\code>.";
Review Comment:
@AndrewJSchofield this should be fixed in https://github.com/apache/kafka/pull/20870/commits/eca686afc1f1eeb874b31fe30bafab6b5f4f73c4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: make description more clear for group.protocol [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield merged PR #20870:
URL: https://github.com/apache/kafka/pull/20870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: make description more clear for group.protocol [kafka]
Posted by "AndrewJSchofield (via GitHub)" <gi...@apache.org>.
AndrewJSchofield commented on PR #20870:
URL: https://github.com/apache/kafka/pull/20870#issuecomment-3529253060
Build green apart from "Collate Test Catalog".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org