[GitHub] [hudi] boneanxs commented on a diff in pull request #9273: [HUDI-6320] Fix partition parsing in Spark file index for custom keygen

["boneanxs (via GitHub)" <gi...@apache.org>]

boneanxs commented on code in PR #9273:
URL: https://github.com/apache/hudi/pull/9273#discussion_r1294272741


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -342,6 +342,16 @@ object HoodieFileIndex extends Logging {
     if (listingModeOverride != null) {
       properties.setProperty(DataSourceReadOptions.FILE_INDEX_LISTING_MODE_OVERRIDE.key, listingModeOverride)
     }
+    val partitionColumns = metaClient.getTableConfig.getPartitionFields
+    if (partitionColumns.isPresent) {
+      // NOTE: Multiple partition fields could have non-encoded slashes in the partition value.
+      //       We might not be able to properly parse partition-values from the listed partition-paths.

Review Comment:
   Hey @codope, if `URL_ENCODE_PARTITIONING` is enabled, it's safe to use lazy file listing?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org