Re: [PR] Avoid referring to PluginBuilderAttribute.class in PluginProcessor [logging-log4j2]

["cushon (via GitHub)" <gi...@apache.org>]

cushon commented on PR #4041:
URL: https://github.com/apache/logging-log4j2/pull/4041#issuecomment-3978669079

   @vy thanks for taking a looking!
   
   > If so, we should be able to simplify the `maven-compiler-plugin` configuration in the `plugin-processing` profile in `/log4j-parent/pom.xml` too, right? Can we carry out this change too, please?
   
   I'm open to trying that, I'm not sure exactly how it would work yet. I noticed this issue trying to build log4j2 with Bazel, not using the maven build, I am less familiar with maven.
   
   This change makes it possible to build the plugins by building just the following sources:
   
   ```
   org/apache/logging/log4j/core/config/plugins/processor/**/*.java
   org/apache/logging/log4j/core/config/plugins/Plugin.java
   org/apache/logging/log4j/core/config/plugins/PluginAliases.java
   org/apache/logging/log4j/core/util/JsonUtils.java
   ```
   
   So it would still be necessary to compile those parts of log4j-core twice, but it might be possible to compile just the above sources in the first phase.
   
   Another option I was wondering about is whether it might be possible to move these processors to a separate maven submodule, to compile them separately before `log4j-core`, and avoid the need for the `maven-compiler-plugin` configuration that compiles in two phases. Do you think that's worth considering?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org