You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/21 01:20:09 UTC
[GitHub] [apisix-dashboard] spacewander opened a new issue #1085: Store the `script.ID` in the router entity?
spacewander opened a new issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085
It seems currently there is not reference between `/apisix/route` and the `/apisix/script`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-769134150
@spacewander @tokers @juzhiyuan
For now, APISIX and manager-api have both supported `script_id` in Route entity. Cause `The script_id is planned to used for debug and optimization(cache). Currently we can assume the script_id is the route's id.`, IMHO there is no need to do anything else in manager FE, so could we close this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-753716975
any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-748709261
That's really, we may add the reference relations just like route and upstream.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-769140784
agree with u.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-768185124
> I think just filling the script_id field with the route id when the script is saved is enough.
@spacewander Wow, that's great. Many thanks for clear directions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-749985034
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-749924833
yes, we need this feature ^_^
APISIX needs to be updated for this feature, all right? @spacewander
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-753718848
APISIX already updated for this feature
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-757913317
ping @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-768149810
> The `script_id` is planned to used for debug and optimization(cache). Currently we can assume the script_id is the route's id.
@spacewander thanks for getting back. So could we have the following assumptions for now:
- Currently users could not manipulate the `script` via manager-api, which means there are no explicite CURDL APIs for `script` object.
- If the `script_id` in request does not equal to the `id` of the affiliated `route`, we can directly send back the `Bad Request` response.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-761803671
All right, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-768129190
> APISIX already updated for this feature
@spacewander AFAIK, APISIX seems not going to deal with loading script by `script_id` from etcd, which acts not the same as `upstream_id`. So just to confirm with you that in manager-api, we must fulfill the `script` property if the input only contains the `script_id`. Please let me know if I'm wrong. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-748731385
sure, we should store it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-768130754
The `script_id` is planned to used for debug and optimization(cache). Currently we can assume the script_id is the route's id.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] spacewander commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-768172872
I think just filling the script_id field with the route id when the script is saved is enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-761802879
> done??
@juzhiyuan I will work on this if no one has taken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-761730420
done??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1085: Store the `script.ID` in the router entity?
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1085:
URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-753735541
ok, waiting manager-api's update.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org