You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2015/01/09 06:58:41 UTC
[23/50] [abbrv] isis git commit: ISIS-1004: using wormhole pattern to
avoid infinite loop
ISIS-1004: using wormhole pattern to avoid infinite loop
Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/16cdd532
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/16cdd532
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/16cdd532
Branch: refs/heads/ISIS-970
Commit: 16cdd532580b855f1b0cd558d0d43eea5ff26529
Parents: 70e3cef
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Thu Jan 8 14:08:52 2015 +0100
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Thu Jan 8 18:15:50 2015 +0100
----------------------------------------------------------------------
.../apache/isis/core/commons/lang/Wormhole.java | 50 ++++++++++++++++++++
.../update/UpdatingCallbackFacetViaMethod.java | 10 ++--
2 files changed, 57 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/isis/blob/16cdd532/core/metamodel/src/main/java/org/apache/isis/core/commons/lang/Wormhole.java
----------------------------------------------------------------------
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/commons/lang/Wormhole.java b/core/metamodel/src/main/java/org/apache/isis/core/commons/lang/Wormhole.java
new file mode 100644
index 0000000..4a88d48
--- /dev/null
+++ b/core/metamodel/src/main/java/org/apache/isis/core/commons/lang/Wormhole.java
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.isis.core.commons.lang;
+
+/**
+ * Provides a mechanism to avoid infinite loops whereby method A -> method B -> method C -> method A and so on.
+ */
+public final class Wormhole {
+
+ private Wormhole(){}
+
+ private ThreadLocal<Boolean> inWormhole = new ThreadLocal<Boolean>() {
+ @Override
+ protected Boolean initialValue() {
+ return false;
+ }
+ };
+
+ public void run(final Runnable runnable) {
+ try {
+ if(inWormhole.get()) {
+ return;
+ }
+ inWormhole.set(true);
+ runnable.run();
+ } finally {
+ inWormhole.set(false);
+ }
+ }
+
+ public static void invoke(final Runnable runnable) {
+ new Wormhole().run(runnable);
+ }
+}
http://git-wip-us.apache.org/repos/asf/isis/blob/16cdd532/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/callbacks/update/UpdatingCallbackFacetViaMethod.java
----------------------------------------------------------------------
diff --git a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/callbacks/update/UpdatingCallbackFacetViaMethod.java b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/callbacks/update/UpdatingCallbackFacetViaMethod.java
index e3fe044..2bdf946 100644
--- a/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/callbacks/update/UpdatingCallbackFacetViaMethod.java
+++ b/core/metamodel/src/main/java/org/apache/isis/core/metamodel/facets/object/callbacks/update/UpdatingCallbackFacetViaMethod.java
@@ -16,14 +16,13 @@
* specific language governing permissions and limitations
* under the License.
*/
-
package org.apache.isis.core.metamodel.facets.object.callbacks.update;
import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
-
+import org.apache.isis.core.commons.lang.Wormhole;
import org.apache.isis.core.metamodel.adapter.ObjectAdapter;
import org.apache.isis.core.metamodel.facetapi.FacetHolder;
import org.apache.isis.core.metamodel.facets.ImperativeFacet;
@@ -64,7 +63,12 @@ public class UpdatingCallbackFacetViaMethod extends UpdatingCallbackFacetAbstrac
@Override
public void invoke(final ObjectAdapter adapter) {
- ObjectAdapter.InvokeUtils.invokeAll(methods, adapter);
+ Wormhole.invoke(new Runnable() {
+ @Override
+ public void run() {
+ ObjectAdapter.InvokeUtils.invokeAll(methods, adapter);
+ }
+ });
}
@Override