[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6028: NIFI-9992 Improve configuration of InfluxDB processors, fix IT

[GitBox <gi...@apache.org>]

exceptionfactory commented on code in PR #6028:
URL: https://github.com/apache/nifi/pull/6028#discussion_r905051766


##########
nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java:
##########
@@ -56,8 +56,8 @@ public abstract class AbstractInfluxDBProcessor extends AbstractProcessor {
             .build();
 
     public static final PropertyDescriptor INFLUX_DB_CONNECTION_TIMEOUT = new PropertyDescriptor.Builder()
-            .name("InfluxDB Max Connection Time Out (seconds)")
-            .displayName("InfluxDB Max Connection Time Out (seconds)")
+            .name("InfluxDB Max Connection Time Out")

Review Comment:
   The property `name` cannot be changed as it would result in breaking existing configurations during an upgrade. Changing the `displayName` is acceptable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org