[jira] [Commented] (PHOENIX-5671) Add tests for ViewUtil

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015469#comment-17015469 ] 

Hadoop QA commented on PHOENIX-5671:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12990917/PHOENIX-5671.patch
  against master branch at commit 6405839b60c410292c0e2c8cbbdee55d09343bab.
  ATTACHMENT ID: 12990917

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+0 tests included{color}.  The patch appears to be a documentation, build,
                        or dev patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +        String tableDDLQuery = "CREATE TABLE " + fullTableName + " (A BIGINT PRIMARY KEY, B BIGINT)";
+                        SchemaUtil.getTableNameFromFullName(fullTableName).getBytes(StandardCharsets.UTF_8),
+                        SchemaUtil.getTableNameFromFullName(secondLevelViewName).getBytes(StandardCharsets.UTF_8)
+                        SchemaUtil.getTableNameFromFullName(thirdLevelViewName4).getBytes(StandardCharsets.UTF_8),
+                        SchemaUtil.getTableNameFromFullName(leafViewName1).getBytes(StandardCharsets.UTF_8),
+                        SchemaUtil.getTableNameFromFullName(leafViewName2).getBytes(StandardCharsets.UTF_8),
+        String multiTenantTableDDL = "CREATE TABLE " + multiTenantTableName + "(TENANT_ID CHAR(10) NOT NULL, " +
+        String globalViewDDL = "CREATE VIEW " + globalViewName + "(PK1 BIGINT, PK2 BIGINT) AS SELECT * FROM "
+        String viewIndexDDL = "CREATE INDEX " + tenantViewIndex + " ON " + tenantViewOnMultiTenantTable2 +
+                        String.format(viewDDL, tenantViewOnMultiTenantTable1, multiTenantTableName));

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3294//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3294//console

This message is automatically generated.

> Add tests for ViewUtil
> ----------------------
>
>                 Key: PHOENIX-5671
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5671
>             Project: Phoenix
>          Issue Type: Test
>    Affects Versions: 4.16.0
>            Reporter: Xinyi Yan
>            Assignee: Xinyi Yan
>            Priority: Minor
>         Attachments: PHOENIX-5671.patch
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Adding tests for ViewUtil to understand hasChildViews, getSystemTableForChildLinks, and other APIs are working as expected.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)