You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Peter Rozsa (Code Review)" <ge...@cloudera.org> on 2026/05/14 13:50:00 UTC
[Impala-ASF-CR] IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
Peter Rozsa has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24303
Change subject: IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
......................................................................
IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
isPartitioned() checks all historical partition specs, not just the
current default spec. A table that was created with a non-VOID partition
spec and then evolved to all-VOID still returns true from
isPartitioned().
The fix guards the partitioned V3 shuffle path with an additional
!targetPartitionExpressions_.isEmpty() check so that a table whose
current spec has no active partition fields uses PARTITION__SPEC__ID
and ICEBERG__PARTITION__SERIALIZED for shuffling.
Testing:
- Added a new test case to iceberg-v3-merge.test.
Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739
---
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-merge.test
2 files changed, 40 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/03/24303/1
--
To view, visit http://gerrit.cloudera.org:8080/24303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739
Gerrit-Change-Number: 24303
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24303 )
Change subject: IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13489/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/24303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739
Gerrit-Change-Number: 24303
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 13:50:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24303 )
Change subject: IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
......................................................................
IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
isPartitioned() checks all historical partition specs, not just the
current default spec. A table that was created with a non-VOID partition
spec and then evolved to all-VOID still returns true from
isPartitioned().
The fix guards the partitioned V3 shuffle path with an additional
!targetPartitionExpressions_.isEmpty() check so that a table whose
current spec has no active partition fields uses PARTITION__SPEC__ID
and ICEBERG__PARTITION__SERIALIZED for shuffling.
Testing:
- Added a new test case to iceberg-v3-merge.test.
Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739
Reviewed-on: http://gerrit.cloudera.org:8080/24303
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-v3-merge.test
2 files changed, 40 insertions(+), 0 deletions(-)
Approvals:
Zoltan Borok-Nagy: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739
Gerrit-Change-Number: 24303
Gerrit-PatchSet: 3
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24303 )
Change subject: IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
LGTM!
http://gerrit.cloudera.org:8080/#/c/24303/2/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java
File fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java:
http://gerrit.cloudera.org:8080/#/c/24303/2/fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java@301
PS2, Line 301: Precondition: targetPartitionExpressions_ is non-empty.
Why not using Preconditions.checkState()?
--
To view, visit http://gerrit.cloudera.org:8080/24303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739
Gerrit-Change-Number: 24303
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 13:56:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24303 )
Change subject: IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739
Gerrit-Change-Number: 24303
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 18:15:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24303 )
Change subject: IMPALA-14937: (addendum) Fix NPE on shuffle expression creation for Iceberg V3 MERGE statements
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/22427/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/24303
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2b0b86deac12e2566d5c24561e120e30b3b6739
Gerrit-Change-Number: 24303
Gerrit-PatchSet: 1
Gerrit-Owner: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 14:01:46 +0000
Gerrit-HasComments: No