[GitHub] [flink] X-czh commented on a diff in pull request #20232: [FLINK-25371] Include data port as part of the host info for subtask detail panel on Web UI

["X-czh (via GitHub)" <gi...@apache.org>]

X-czh commented on code in PR #20232:
URL: https://github.com/apache/flink/pull/20232#discussion_r1289957395


##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/job/SubtaskExecutionAttemptDetailsInfo.java:
##########
@@ -203,7 +203,10 @@ public static SubtaskExecutionAttemptDetailsInfo create(
         final long now = System.currentTimeMillis();
 
         final TaskManagerLocation location = execution.getAssignedResourceLocation();
-        final String locationString = location == null ? "(unassigned)" : location.getHostname();
+        final String locationString =

Review Comment:
   Thanks for the comment, I'll align the location generation logic in different places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org