You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by kevdoran <gi...@git.apache.org> on 2017/12/21 02:08:43 UTC

[GitHub] nifi-registry pull request #64: NIFIREG-75 Add check for user when updating ...

GitHub user kevdoran opened a pull request:

    https://github.com/apache/nifi-registry/pull/64

    NIFIREG-75 Add check for user when updating group

    Adds a check that users are known to the FileUserGroupProvider prior
    to allowing an update. This fixes a corner-case bug when using a
    CompositeConfigurableUserGroupProvider with a FileUserGroupProvider
    as the configurable provider along with another provider, such as
    LdapUserGroupProvider, in which it was possible to add users from
    the Ldap provider to groups in the file provider.
    
    Also updates a package in the authorizers.xml template.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevdoran/nifi-registry NIFIREG-75

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-registry/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit 0eefbc29b604d646e90cc9d8d4b39fbb08cbe419
Author: Kevin Doran <kd...@...>
Date:   2017-12-21T01:57:20Z

    NIFIREG-75 Add check for user when updating group
    
    Adds a check that users are known to the FileUserGroupProvider prior
    to allowing an update. This fixes a corner-case bug when using a
    CompositeConfigurableUserGroupProvider with a FileUserGroupProvider
    as the configurable provider along with another provider, such as
    LdapUserGroupProvider, in which it was possible to add users from
    the Ldap provider to groups in the file provider.
    
    Also updates a package in the authorizers.xml template.

----


---

[GitHub] nifi-registry issue #64: NIFIREG-75 Fix User Groups for Composite Provider C...

Posted by bbende <gi...@git.apache.org>.

Github user bbende commented on the issue:

    https://github.com/apache/nifi-registry/pull/64
  
    Reviewing...


---

[GitHub] nifi-registry issue #64: NIFIREG-75 Fix User Group Data Integrity Checks

Posted by kevdoran <gi...@git.apache.org>.

Github user kevdoran commented on the issue:

    https://github.com/apache/nifi-registry/pull/64
  
    This has been updated with the latest approach


---

[GitHub] nifi-registry issue #64: NIFIREG-75 Add check for user when updating group

Posted by kevdoran <gi...@git.apache.org>.

Github user kevdoran commented on the issue:

    https://github.com/apache/nifi-registry/pull/64
  
    Upon further discussion, may go with a different approach here. please hold off on merging this for now


---

[GitHub] nifi-registry pull request #64: NIFIREG-75 Fix User Groups for Composite Pro...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi-registry/pull/64


---

[GitHub] nifi-registry issue #64: NIFIREG-75 Fix User Groups for Composite Provider C...

Posted by bbende <gi...@git.apache.org>.

Github user bbende commented on the issue:

    https://github.com/apache/nifi-registry/pull/64
  
    +1 Ran through a full test with NiFi & Registry both configured with a composite user-group-provider, and put an LDAP user into a file-based group, and then made a bucket and gave the group access to that bucket, verified the LDAP user could use that bucket from NiFi... nice work


---