You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Alejandro Fernandez <af...@hortonworks.com> on 2017/01/16 23:30:03 UTC

Re: Review Request 55529: HDP 3.0 TP - create Service Advisor for HDFS

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55529/
-----------------------------------------------------------

(Updated Jan. 16, 2017, 11:30 p.m.)


Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Sumit Mohanty, and Sid Wagle.


Changes
-------

Rebased.


Summary (updated)
-----------------

HDP 3.0 TP - create Service Advisor for HDFS


Bugs: AMBARI-19097
    https://issues.apache.org/jira/browse/AMBARI-19097


Repository: ambari


Description
-------

Create a Service Advisor script for HDFS in HDP 3.0 Tech Preview.
The Service Advisor must encapsulate all of the logic inherited/overwritten from HDP 2.0.6 through HDP 2.6


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/service_advisor.py 82316f4 
  ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 5172042 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 9816702 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py b275b00 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 8980398 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 4e4ef51 
  ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 26292d9 
  ambari-server/src/main/resources/stacks/stack_advisor.py cc556c6 
  ambari-server/src/test/python/TestStackAdvisor.py 87d2d15 
  ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 1145154 
  ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py f9fb1f5 

Diff: https://reviews.apache.org/r/55529/diff/


Testing
-------

Verified recommendation and validation of HDFS while deploying HDP 3.0

Python unit tests passed.

Total run:1157
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 55529: HDP 3.0 TP - create Service Advisor for HDFS

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55529/#review161806
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Jan. 16, 2017, 11:30 p.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55529/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 11:30 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19097
>     https://issues.apache.org/jira/browse/AMBARI-19097
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a Service Advisor script for HDFS in HDP 3.0 Tech Preview.
> The Service Advisor must encapsulate all of the logic inherited/overwritten from HDP 2.0.6 through HDP 2.6
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/service_advisor.py 82316f4 
>   ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py 5172042 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 9816702 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py b275b00 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 8980398 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py 4e4ef51 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py 26292d9 
>   ambari-server/src/main/resources/stacks/stack_advisor.py cc556c6 
>   ambari-server/src/test/python/TestStackAdvisor.py 87d2d15 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 1145154 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py f9fb1f5 
> 
> Diff: https://reviews.apache.org/r/55529/diff/
> 
> 
> Testing
> -------
> 
> Verified recommendation and validation of HDFS while deploying HDP 3.0
> 
> Python unit tests passed.
> 
> Total run:1157
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>