You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "hrsstd (GitHub)" <gi...@apache.org> on 2019/01/03 10:51:59 UTC
[GitHub] [incubator-dubbo-ops] hrsstd opened pull request #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
1. 对 ServiceDTO 重写equals、hashCode方法, 在ServiceController内 Set集合中使用保证数据唯一性。
2. ServiceController 内部魔数定义
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/956b60ec7507497f37813a15e4e3a80702e4c207?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 82
Lines 3284 3292 +8
Branches 521 524 +3
============================================
Hits 19 19
- Misses 3264 3272 +8
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/util/Constants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/admin/model/dto/ServiceDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VEVE8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=footer). Last update [956b60e...ace2cc0](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] hrsstd commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "hrsstd (GitHub)" <gi...@apache.org>.
Choose English as comment
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/956b60ec7507497f37813a15e4e3a80702e4c207?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 83 +1
Lines 3284 3293 +9
Branches 521 524 +3
============================================
Hits 19 19
- Misses 3264 3273 +9
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...va/org/apache/dubbo/admin/config/ConfigCenter.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29uZmlnL0NvbmZpZ0NlbnRlci5qYXZh) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [.../org/apache/dubbo/admin/common/AdminConstants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL0FkbWluQ29uc3RhbnRzLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/admin/model/dto/ServiceDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VEVE8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=footer). Last update [956b60e...190d255](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/956b60ec7507497f37813a15e4e3a80702e4c207?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 82
Lines 3284 3292 +8
Branches 521 524 +3
============================================
Hits 19 19
- Misses 3264 3272 +8
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/util/Constants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/admin/model/dto/ServiceDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VEVE8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=footer). Last update [956b60e...24457fb](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] hrsstd closed pull request #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "hrsstd (GitHub)" <gi...@apache.org>.
[ pull request closed by hrsstd ]
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] hrsstd commented on pull request #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "hrsstd (GitHub)" <gi...@apache.org>.
get
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/956b60ec7507497f37813a15e4e3a80702e4c207?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 82
Lines 3284 3292 +8
Branches 521 524 +3
============================================
Hits 19 19
- Misses 3264 3272 +8
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/util/Constants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/admin/model/dto/ServiceDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VEVE8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=footer). Last update [956b60e...24457fb](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] hrsstd commented on pull request #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "hrsstd (GitHub)" <gi...@apache.org>.
ok , thank you. Later I will add these again.
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/956b60ec7507497f37813a15e4e3a80702e4c207?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 82
Lines 3284 3292 +8
Branches 521 524 +3
============================================
Hits 19 19
- Misses 3264 3272 +8
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/util/Constants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/admin/model/dto/ServiceDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VEVE8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=footer). Last update [956b60e...4448811](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia commented on pull request #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
We already have a class: `org.apache.dubbo.admin.common.util.Constants`, please add these variables there.
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia commented on pull request #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
this format change is unnecessary
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] nzomkxia commented on pull request #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "nzomkxia (GitHub)" <gi...@apache.org>.
both dubbo.configcenter and dubbo.registrey.address are necessary here, do not change
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/956b60ec7507497f37813a15e4e3a80702e4c207?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 82
Lines 3284 3292 +8
Branches 521 524 +3
============================================
Hits 19 19
- Misses 3264 3272 +8
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/util/Constants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/admin/model/dto/ServiceDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VEVE8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=footer). Last update [956b60e...ace2cc0](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/956b60ec7507497f37813a15e4e3a80702e4c207?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 83 +1
Lines 3284 3293 +9
Branches 521 524 +3
============================================
Hits 19 19
- Misses 3264 3273 +9
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/AdminConstants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL0FkbWluQ29uc3RhbnRzLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/admin/model/dto/ServiceDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VEVE8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=footer). Last update [956b60e...0f8eafa](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/956b60ec7507497f37813a15e4e3a80702e4c207?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 83 +1
Lines 3284 3293 +9
Branches 521 524 +3
============================================
Hits 19 19
- Misses 3264 3273 +9
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/AdminConstants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL0FkbWluQ29uc3RhbnRzLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/admin/model/dto/ServiceDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VEVE8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=footer). Last update [956b60e...0f8eafa](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] hrsstd commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "hrsstd (GitHub)" <gi...@apache.org>.
Hi , nzomkxia ,I have to resubmit，please review again。
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] hrsstd commented on pull request #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "hrsstd (GitHub)" <gi...@apache.org>.
if don't change this , can I change the application.properties add a config ?
like this: dubbo.registry.address=zookeeper://127.0.0.1:2181
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo-ops] codecov-io commented on issue #228: 对 ServiceDTO 重写equals、hashCode方法, ServiceController内魔数整理
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/incubator-dubbo-ops/commit/956b60ec7507497f37813a15e4e3a80702e4c207?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #228 +/- ##
============================================
- Coverage 0.57% 0.57% -0.01%
Complexity 7 7
============================================
Files 82 82
Lines 3284 3292 +8
Branches 521 524 +3
============================================
Hits 19 19
- Misses 3264 3272 +8
Partials 1 1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/dubbo/admin/common/util/Constants.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29tbW9uL3V0aWwvQ29uc3RhbnRzLmphdmE=) | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ache/dubbo/admin/controller/ServiceController.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vY29udHJvbGxlci9TZXJ2aWNlQ29udHJvbGxlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...a/org/apache/dubbo/admin/model/dto/ServiceDTO.java](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228/diff?src=pr&el=tree#diff-ZHViYm8tYWRtaW4tYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vYWRtaW4vbW9kZWwvZHRvL1NlcnZpY2VEVE8uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=footer). Last update [956b60e...4448811](https://codecov.io/gh/apache/incubator-dubbo-ops/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo-ops/pull/228 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org