[GitHub] [iceberg] jun-he commented on a change in pull request #2866: [Python] Support schema field ID validation in python

[GitBox <gi...@apache.org>]

jun-he commented on a change in pull request #2866:
URL: https://github.com/apache/iceberg/pull/2866#discussion_r679267907



##########
File path: python/iceberg/api/types/type_util.py
##########
@@ -117,15 +119,17 @@ def visit(arg, visitor): # noqa: ignore=C901
             results = list()
             for field in struct.fields:
                 visitor.field_ids.append(field.field_id)
-                visitor.field_names.append(field.name)
+                visitor.field_names.appendleft(field.name)

Review comment:
       Use it to match Java implementation. Currently it is a list but the [full name generated](https://github.com/apache/iceberg/blob/master/python/iceberg/api/types/type_util.py#L356) later will be wrong.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org