You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/06/29 12:08:33 UTC
[GitHub] [cloudstack] sureshanaparti commented on a diff in pull request #6513: cks: fix k8s version upgrade
sureshanaparti commented on code in PR #6513:
URL: https://github.com/apache/cloudstack/pull/6513#discussion_r909549079
##########
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java:
##########
@@ -324,4 +326,38 @@ public static String generateClusterHACertificateKey(final KubernetesCluster kub
}
return token.toString().substring(0, 64);
}
+
+ public static boolean clusterNodeVersionMatches(final String version, boolean isControlNode,
+ final String ipAddress, final int port,
+ final String user, final File sshKeyFile,
+ final String hostName) {
+ Pair<Boolean, String> result = null;
+ try {
+ result = SshHelper.sshExecute(
+ ipAddress, port,
+ user, sshKeyFile, null,
+ "sudo /opt/bin/kubectl version --short",
Review Comment:
```suggestion
CLUSTER_NODE_VERSION_COMMAND,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org