You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/06/05 11:27:02 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #383: Fixing wrong labels
davidjumani opened a new pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383
Fixes incorrect labels as well as add new ones to `en.json`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#discussion_r435861717
##########
File path: src/locales/en.json
##########
@@ -704,7 +706,6 @@
"label.dns1": "DNS 1",
"label.dns2": "DNS 2",
"label.domain": "Domain",
-"label.domains": "Domain",
Review comment:
It is a duplicate key, L:716
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#issuecomment-641977179
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#discussion_r435859880
##########
File path: src/locales/en.json
##########
@@ -704,7 +706,6 @@
"label.dns1": "DNS 1",
"label.dns2": "DNS 2",
"label.domain": "Domain",
-"label.domains": "Domain",
Review comment:
don't remember keys even if they look redundant @davidjumani - it's used in section/titles and few other places
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#discussion_r437362987
##########
File path: src/locales/en.json
##########
@@ -29,6 +29,7 @@
"inline": "Inline",
"label.about": "About",
"label.about.app": "About CloudStack",
+"label.accept": "Accept",
Review comment:
https://github.com/apache/cloudstack-primate/blob/master/src/views/offering/AddNetworkOffering.vue#L108
##########
File path: src/locales/en.json
##########
@@ -704,7 +706,6 @@
"label.dns1": "DNS 1",
"label.dns2": "DNS 2",
"label.domain": "Domain",
-"label.domains": "Domain",
Review comment:
Done!
##########
File path: src/views/storage/ResizeVolume.vue
##########
@@ -24,7 +24,7 @@
initialValue: selectedDiskOfferingId,
rules: [{ required: true, message: 'Please select an option' }]}]"
:loading="loading"
- :placeholder="$t('label.offering.type')"
+ :placeholder="$t('label.diskoffering.type')"
Review comment:
Done
##########
File path: src/locales/en.json
##########
@@ -1426,6 +1432,7 @@
"label.portableipaddress": "Portable IPs",
"label.portforwarding": "Port Forwarding",
"label.powerstate": "Power State",
+"label.preferred": "Prefered",
Review comment:
https://github.com/apache/cloudstack-primate/blob/master/src/views/offering/AddComputeOffering.vue#L434
##########
File path: src/locales/en.json
##########
@@ -1539,6 +1549,7 @@
"label.region": "Region",
"label.region.details": "Region details",
"label.reinstall.vm": "Reinstall VM",
+"label.reject": "Reject",
Review comment:
Was reject itself, but as an inline string
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#discussion_r437361061
##########
File path: src/locales/en.json
##########
@@ -29,6 +29,7 @@
"inline": "Inline",
"label.about": "About",
"label.about.app": "About CloudStack",
+"label.accept": "Accept",
Review comment:
where is this used @davidjumani ?
##########
File path: src/views/storage/ResizeVolume.vue
##########
@@ -24,7 +24,7 @@
initialValue: selectedDiskOfferingId,
rules: [{ required: true, message: 'Please select an option' }]}]"
:loading="loading"
- :placeholder="$t('label.offering.type')"
+ :placeholder="$t('label.diskoffering.type')"
Review comment:
See the param is `diskofferingid`, so instead of this we can simply call it `label.diskoffering`
##########
File path: src/locales/en.json
##########
@@ -686,6 +687,7 @@
"label.diskkbsread": "Disk Read (Bytes)",
"label.diskkbswrite": "Disk Write (Bytes)",
"label.diskoffering": "Disk Offering",
+"label.diskoffering.type": "Disk Offering Type",
Review comment:
Not necessary, see comment below around the usage.
##########
File path: src/locales/en.json
##########
@@ -1019,6 +1020,7 @@
"label.iso.id": "ISO ID",
"label.iso.name": "ISO name",
"label.isoid": "ISO",
+"label.isolated": "Isolated",
Review comment:
There is a way to avoid this, will check tomorrow.
##########
File path: src/views/offering/AddNetworkOffering.vue
##########
@@ -273,7 +273,7 @@
<a-form-item :label="$t('label.tags')">
<a-input
v-decorator="['tags', {}]"
- :placeholder="this.$t('label.networktags')"/>
Review comment:
We can simply call it tags - note the :label already uses label.tags.
##########
File path: src/locales/en.json
##########
@@ -1277,6 +1280,7 @@
"label.network.offering.name": "Network Offering Name",
"label.network.offerings": "Network Offerings",
"label.network.service.providers": "Network Service Providers",
+"label.network.tags": "Network Tags",
Review comment:
Not necessary.
##########
File path: src/locales/en.json
##########
@@ -1068,6 +1070,7 @@
"label.kubernetesversionid": "Kubernetes version",
"label.kubernetesversionname": "Kubernetes version",
"label.kvmnetworklabel": "KVM Traffic Label",
+"label.l2": "L2",
Review comment:
same as above
##########
File path: src/locales/en.json
##########
@@ -1426,6 +1432,7 @@
"label.portableipaddress": "Portable IPs",
"label.portforwarding": "Port Forwarding",
"label.powerstate": "Power State",
+"label.preferred": "Prefered",
Review comment:
Where is this used?
##########
File path: src/locales/en.json
##########
@@ -1539,6 +1549,7 @@
"label.region": "Region",
"label.region.details": "Region details",
"label.reinstall.vm": "Reinstall VM",
+"label.reject": "Reject",
Review comment:
check old UI, for add network offering; if reject is used or something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#issuecomment-641978541
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#issuecomment-641982971
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/383 (JID-1988)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#discussion_r439705791
##########
File path: src/locales/en.json
##########
@@ -1426,6 +1432,7 @@
"label.portableipaddress": "Portable IPs",
"label.portforwarding": "Port Forwarding",
"label.powerstate": "Power State",
+"label.preferred": "Prefered",
Review comment:
Sorry older master, that's why I didn't catch it with git grep
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
davidjumani commented on a change in pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#discussion_r435861717
##########
File path: src/locales/en.json
##########
@@ -704,7 +706,6 @@
"label.dns1": "DNS 1",
"label.dns2": "DNS 2",
"label.domain": "Domain",
-"label.domains": "Domain",
Review comment:
It is a duplicate key, L:716
Also sorted the keys and removed duplicates
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #383: Fixing wrong labels
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #383:
URL: https://github.com/apache/cloudstack-primate/pull/383#discussion_r436095590
##########
File path: src/locales/en.json
##########
@@ -704,7 +706,6 @@
"label.dns1": "DNS 1",
"label.dns2": "DNS 2",
"label.domain": "Domain",
-"label.domains": "Domain",
Review comment:
ah okay good catch; maybe we should sort and de-dupe the list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org