You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by Sergey Beryozkin <sb...@gmail.com> on 2016/07/04 13:51:48 UTC
Moving CXF SwaggerFeature into its own module
Hi All
as part of CXF-6760 [1] I've moved the Swagger code into its own
cxf-rt-rs-description-swagger module.
It makes it easier for the users to choose between WADL and Swagger
(example, right now if only WADL is preferred then no Swagger endpoint
is there but not vice versa, having Swagger endpoint automatically adds
a WADL filter simply because they share the same module and CXF tries to
install WADL by default) and simplify the user dependencies (they'd only
have to refer to this new module and not list explicitly swagger-jaxrs).
So far it is only done on master, and would like to update 3.1.7 too - a
minor migration issue is expected but the positive effect will be
immediate. The fact that having a WADL filter for Swagger users is
inevitable at 3.1.x can be considered a bug too
If you have any concerns about a 3.1.x update then let me know please
today.
Thanks, Sergey
[1] ttps://issues.apache.org/jira/browse/CXF-6760
[2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
Re: Moving CXF SwaggerFeature into its own module
Posted by Sergey Beryozkin <sb...@gmail.com>.
Have just merged to 3.1.x.
Cheers, Sergey
On 04/07/16 16:32, Sergey Beryozkin wrote:
> Hi Andriy
>
> Romain proposed it earlier, I agree it is quite timely at this stage :-)
> Cheers, Sergey
> On 04/07/16 15:53, Andrey Redko wrote:
>> Hey Sergey,
>>
>> Great idea I think, we may add even more features around Swagger,
>> awesome timing for that.
>> Thanks!
>>
>> Best Regards,
>> Andriy Redko
>>
>> On Mon, Jul 4, 2016 at 9:51 AM, Sergey Beryozkin <sberyozkin@gmail.com
>> <ma...@gmail.com>> wrote:
>>
>> Hi All
>>
>> as part of CXF-6760 [1] I've moved the Swagger code into its own
>> cxf-rt-rs-description-swagger module.
>> It makes it easier for the users to choose between WADL and Swagger
>> (example, right now if only WADL is preferred then no Swagger
>> endpoint is there but not vice versa, having Swagger endpoint
>> automatically adds a WADL filter simply because they share the same
>> module and CXF tries to install WADL by default) and simplify the
>> user dependencies (they'd only have to refer to this new module and
>> not list explicitly swagger-jaxrs).
>>
>> So far it is only done on master, and would like to update 3.1.7 too
>> - a minor migration issue is expected but the positive effect will
>> be immediate. The fact that having a WADL filter for Swagger users
>> is inevitable at 3.1.x can be considered a bug too
>>
>> If you have any concerns about a 3.1.x update then let me know
>> please today.
>>
>> Thanks, Sergey
>>
>> [1] ttps://issues.apache.org/jira/browse/CXF-6760
>> <http://issues.apache.org/jira/browse/CXF-6760>
>>
>> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
>>
>>
>
>
--
Sergey Beryozkin
Talend Community Coders
http://coders.talend.com/
Re: Moving CXF SwaggerFeature into its own module
Posted by Sergey Beryozkin <sb...@gmail.com>.
Have just merged to 3.1.x.
Cheers, Sergey
On 04/07/16 16:32, Sergey Beryozkin wrote:
> Hi Andriy
>
> Romain proposed it earlier, I agree it is quite timely at this stage :-)
> Cheers, Sergey
> On 04/07/16 15:53, Andrey Redko wrote:
>> Hey Sergey,
>>
>> Great idea I think, we may add even more features around Swagger,
>> awesome timing for that.
>> Thanks!
>>
>> Best Regards,
>> Andriy Redko
>>
>> On Mon, Jul 4, 2016 at 9:51 AM, Sergey Beryozkin <sberyozkin@gmail.com
>> <ma...@gmail.com>> wrote:
>>
>> Hi All
>>
>> as part of CXF-6760 [1] I've moved the Swagger code into its own
>> cxf-rt-rs-description-swagger module.
>> It makes it easier for the users to choose between WADL and Swagger
>> (example, right now if only WADL is preferred then no Swagger
>> endpoint is there but not vice versa, having Swagger endpoint
>> automatically adds a WADL filter simply because they share the same
>> module and CXF tries to install WADL by default) and simplify the
>> user dependencies (they'd only have to refer to this new module and
>> not list explicitly swagger-jaxrs).
>>
>> So far it is only done on master, and would like to update 3.1.7 too
>> - a minor migration issue is expected but the positive effect will
>> be immediate. The fact that having a WADL filter for Swagger users
>> is inevitable at 3.1.x can be considered a bug too
>>
>> If you have any concerns about a 3.1.x update then let me know
>> please today.
>>
>> Thanks, Sergey
>>
>> [1] ttps://issues.apache.org/jira/browse/CXF-6760
>> <http://issues.apache.org/jira/browse/CXF-6760>
>>
>> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
>>
>>
>
>
--
Sergey Beryozkin
Talend Community Coders
http://coders.talend.com/
Re: Moving CXF SwaggerFeature into its own module
Posted by Sergey Beryozkin <sb...@gmail.com>.
Hi Andriy
Romain proposed it earlier, I agree it is quite timely at this stage :-)
Cheers, Sergey
On 04/07/16 15:53, Andrey Redko wrote:
> Hey Sergey,
>
> Great idea I think, we may add even more features around Swagger,
> awesome timing for that.
> Thanks!
>
> Best Regards,
> Andriy Redko
>
> On Mon, Jul 4, 2016 at 9:51 AM, Sergey Beryozkin <sberyozkin@gmail.com
> <ma...@gmail.com>> wrote:
>
> Hi All
>
> as part of CXF-6760 [1] I've moved the Swagger code into its own
> cxf-rt-rs-description-swagger module.
> It makes it easier for the users to choose between WADL and Swagger
> (example, right now if only WADL is preferred then no Swagger
> endpoint is there but not vice versa, having Swagger endpoint
> automatically adds a WADL filter simply because they share the same
> module and CXF tries to install WADL by default) and simplify the
> user dependencies (they'd only have to refer to this new module and
> not list explicitly swagger-jaxrs).
>
> So far it is only done on master, and would like to update 3.1.7 too
> - a minor migration issue is expected but the positive effect will
> be immediate. The fact that having a WADL filter for Swagger users
> is inevitable at 3.1.x can be considered a bug too
>
> If you have any concerns about a 3.1.x update then let me know
> please today.
>
> Thanks, Sergey
>
> [1] ttps://issues.apache.org/jira/browse/CXF-6760
> <http://issues.apache.org/jira/browse/CXF-6760>
>
> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
>
>
--
Sergey Beryozkin
Talend Community Coders
http://coders.talend.com/
Re: Moving CXF SwaggerFeature into its own module
Posted by Sergey Beryozkin <sb...@gmail.com>.
Hi Andriy
Romain proposed it earlier, I agree it is quite timely at this stage :-)
Cheers, Sergey
On 04/07/16 15:53, Andrey Redko wrote:
> Hey Sergey,
>
> Great idea I think, we may add even more features around Swagger,
> awesome timing for that.
> Thanks!
>
> Best Regards,
> Andriy Redko
>
> On Mon, Jul 4, 2016 at 9:51 AM, Sergey Beryozkin <sberyozkin@gmail.com
> <ma...@gmail.com>> wrote:
>
> Hi All
>
> as part of CXF-6760 [1] I've moved the Swagger code into its own
> cxf-rt-rs-description-swagger module.
> It makes it easier for the users to choose between WADL and Swagger
> (example, right now if only WADL is preferred then no Swagger
> endpoint is there but not vice versa, having Swagger endpoint
> automatically adds a WADL filter simply because they share the same
> module and CXF tries to install WADL by default) and simplify the
> user dependencies (they'd only have to refer to this new module and
> not list explicitly swagger-jaxrs).
>
> So far it is only done on master, and would like to update 3.1.7 too
> - a minor migration issue is expected but the positive effect will
> be immediate. The fact that having a WADL filter for Swagger users
> is inevitable at 3.1.x can be considered a bug too
>
> If you have any concerns about a 3.1.x update then let me know
> please today.
>
> Thanks, Sergey
>
> [1] ttps://issues.apache.org/jira/browse/CXF-6760
> <http://issues.apache.org/jira/browse/CXF-6760>
>
> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
>
>
--
Sergey Beryozkin
Talend Community Coders
http://coders.talend.com/
Re: Moving CXF SwaggerFeature into its own module
Posted by Andrey Redko <dr...@gmail.com>.
Hey Sergey,
Great idea I think, we may add even more features around Swagger, awesome
timing for that.
Thanks!
Best Regards,
Andriy Redko
On Mon, Jul 4, 2016 at 9:51 AM, Sergey Beryozkin <sb...@gmail.com>
wrote:
> Hi All
>
> as part of CXF-6760 [1] I've moved the Swagger code into its own
> cxf-rt-rs-description-swagger module.
> It makes it easier for the users to choose between WADL and Swagger
> (example, right now if only WADL is preferred then no Swagger endpoint is
> there but not vice versa, having Swagger endpoint automatically adds a WADL
> filter simply because they share the same module and CXF tries to install
> WADL by default) and simplify the user dependencies (they'd only have to
> refer to this new module and not list explicitly swagger-jaxrs).
>
> So far it is only done on master, and would like to update 3.1.7 too - a
> minor migration issue is expected but the positive effect will be
> immediate. The fact that having a WADL filter for Swagger users is
> inevitable at 3.1.x can be considered a bug too
>
> If you have any concerns about a 3.1.x update then let me know please
> today.
>
> Thanks, Sergey
>
> [1] ttps://issues.apache.org/jira/browse/CXF-6760
>
> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
>
Re: Moving CXF SwaggerFeature into its own module
Posted by Andrey Redko <dr...@gmail.com>.
Hey Sergey,
Great idea I think, we may add even more features around Swagger, awesome
timing for that.
Thanks!
Best Regards,
Andriy Redko
On Mon, Jul 4, 2016 at 9:51 AM, Sergey Beryozkin <sb...@gmail.com>
wrote:
> Hi All
>
> as part of CXF-6760 [1] I've moved the Swagger code into its own
> cxf-rt-rs-description-swagger module.
> It makes it easier for the users to choose between WADL and Swagger
> (example, right now if only WADL is preferred then no Swagger endpoint is
> there but not vice versa, having Swagger endpoint automatically adds a WADL
> filter simply because they share the same module and CXF tries to install
> WADL by default) and simplify the user dependencies (they'd only have to
> refer to this new module and not list explicitly swagger-jaxrs).
>
> So far it is only done on master, and would like to update 3.1.7 too - a
> minor migration issue is expected but the positive effect will be
> immediate. The fact that having a WADL filter for Swagger users is
> inevitable at 3.1.x can be considered a bug too
>
> If you have any concerns about a 3.1.x update then let me know please
> today.
>
> Thanks, Sergey
>
> [1] ttps://issues.apache.org/jira/browse/CXF-6760
>
> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
>
Re: Moving CXF SwaggerFeature into its own module
Posted by Francesco Chicchiriccò <il...@apache.org>.
On 04/07/2016 16:04, Sergey Beryozkin wrote:
> Hi Francesco
>
> Thanks, FYI, the initial commit only showed that the Swagger resources
> were deleted :-)
>
> Here is the one with the newly added resources:
>
> http://git-wip-us.apache.org/repos/asf/cxf/commit/636252c2
Whoops :-)
> On 04/07/16 14:59, Francesco Chicchiricc� wrote:
>> On 04/07/2016 15:51, Sergey Beryozkin wrote:
>>> Hi All
>>>
>>> as part of CXF-6760 [1] I've moved the Swagger code into its own
>>> cxf-rt-rs-description-swagger module.
>>> It makes it easier for the users to choose between WADL and Swagger
>>> (example, right now if only WADL is preferred then no Swagger endpoint
>>> is there but not vice versa, having Swagger endpoint automatically
>>> adds a WADL filter simply because they share the same module and CXF
>>> tries to install WADL by default) and simplify the user dependencies
>>> (they'd only have to refer to this new module and not list explicitly
>>> swagger-jaxrs).
>>>
>>> So far it is only done on master, and would like to update 3.1.7 too -
>>> a minor migration issue is expected but the positive effect will be
>>> immediate. The fact that having a WADL filter for Swagger users is
>>> inevitable at 3.1.x can be considered a bug too
>>>
>>> If you have any concerns about a 3.1.x update then let me know please
>>> today.
>>
>> Hi Sergey,
>> definitely a good idea to clean up and separate things.
>>
>> Since Swagger is an optional extension for Syncope, I would also have
>> the chance to adapt its CXF configuration according to the changes that
>> will be part of CXF 3.1.7.
>>
>> Thanks for taking care of this.
>>
>> Regards.
>>
>>> [1] ttps://issues.apache.org/jira/browse/CXF-6760
>>> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
--
Francesco Chicchiricc�
Tirasa - Open Source Excellence
http://www.tirasa.net/
Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC,
CXF Committer, OpenJPA Committer, PonyMail PPMC
http://home.apache.org/~ilgrosso/
Re: Moving CXF SwaggerFeature into its own module
Posted by Francesco Chicchiriccò <il...@apache.org>.
On 04/07/2016 16:04, Sergey Beryozkin wrote:
> Hi Francesco
>
> Thanks, FYI, the initial commit only showed that the Swagger resources
> were deleted :-)
>
> Here is the one with the newly added resources:
>
> http://git-wip-us.apache.org/repos/asf/cxf/commit/636252c2
Whoops :-)
> On 04/07/16 14:59, Francesco Chicchiricc� wrote:
>> On 04/07/2016 15:51, Sergey Beryozkin wrote:
>>> Hi All
>>>
>>> as part of CXF-6760 [1] I've moved the Swagger code into its own
>>> cxf-rt-rs-description-swagger module.
>>> It makes it easier for the users to choose between WADL and Swagger
>>> (example, right now if only WADL is preferred then no Swagger endpoint
>>> is there but not vice versa, having Swagger endpoint automatically
>>> adds a WADL filter simply because they share the same module and CXF
>>> tries to install WADL by default) and simplify the user dependencies
>>> (they'd only have to refer to this new module and not list explicitly
>>> swagger-jaxrs).
>>>
>>> So far it is only done on master, and would like to update 3.1.7 too -
>>> a minor migration issue is expected but the positive effect will be
>>> immediate. The fact that having a WADL filter for Swagger users is
>>> inevitable at 3.1.x can be considered a bug too
>>>
>>> If you have any concerns about a 3.1.x update then let me know please
>>> today.
>>
>> Hi Sergey,
>> definitely a good idea to clean up and separate things.
>>
>> Since Swagger is an optional extension for Syncope, I would also have
>> the chance to adapt its CXF configuration according to the changes that
>> will be part of CXF 3.1.7.
>>
>> Thanks for taking care of this.
>>
>> Regards.
>>
>>> [1] ttps://issues.apache.org/jira/browse/CXF-6760
>>> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
--
Francesco Chicchiricc�
Tirasa - Open Source Excellence
http://www.tirasa.net/
Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC,
CXF Committer, OpenJPA Committer, PonyMail PPMC
http://home.apache.org/~ilgrosso/
Re: Moving CXF SwaggerFeature into its own module
Posted by Sergey Beryozkin <sb...@gmail.com>.
Hi Francesco
Thanks, FYI, the initial commit only showed that the Swagger resources
were deleted :-)
Here is the one with the newly added resources:
http://git-wip-us.apache.org/repos/asf/cxf/commit/636252c2
Thanks, Sergey
On 04/07/16 14:59, Francesco Chicchiricc� wrote:
> On 04/07/2016 15:51, Sergey Beryozkin wrote:
>> Hi All
>>
>> as part of CXF-6760 [1] I've moved the Swagger code into its own
>> cxf-rt-rs-description-swagger module.
>> It makes it easier for the users to choose between WADL and Swagger
>> (example, right now if only WADL is preferred then no Swagger endpoint
>> is there but not vice versa, having Swagger endpoint automatically
>> adds a WADL filter simply because they share the same module and CXF
>> tries to install WADL by default) and simplify the user dependencies
>> (they'd only have to refer to this new module and not list explicitly
>> swagger-jaxrs).
>>
>> So far it is only done on master, and would like to update 3.1.7 too -
>> a minor migration issue is expected but the positive effect will be
>> immediate. The fact that having a WADL filter for Swagger users is
>> inevitable at 3.1.x can be considered a bug too
>>
>> If you have any concerns about a 3.1.x update then let me know please
>> today.
>
> Hi Sergey,
> definitely a good idea to clean up and separate things.
>
> Since Swagger is an optional extension for Syncope, I would also have
> the chance to adapt its CXF configuration according to the changes that
> will be part of CXF 3.1.7.
>
> Thanks for taking care of this.
>
> Regards.
>
>> [1] ttps://issues.apache.org/jira/browse/CXF-6760
>> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
>
--
Sergey Beryozkin
Talend Community Coders
http://coders.talend.com/
Re: Moving CXF SwaggerFeature into its own module
Posted by Francesco Chicchiriccò <il...@apache.org>.
On 04/07/2016 15:51, Sergey Beryozkin wrote:
> Hi All
>
> as part of CXF-6760 [1] I've moved the Swagger code into its own
> cxf-rt-rs-description-swagger module.
> It makes it easier for the users to choose between WADL and Swagger
> (example, right now if only WADL is preferred then no Swagger endpoint
> is there but not vice versa, having Swagger endpoint automatically
> adds a WADL filter simply because they share the same module and CXF
> tries to install WADL by default) and simplify the user dependencies
> (they'd only have to refer to this new module and not list explicitly
> swagger-jaxrs).
>
> So far it is only done on master, and would like to update 3.1.7 too -
> a minor migration issue is expected but the positive effect will be
> immediate. The fact that having a WADL filter for Swagger users is
> inevitable at 3.1.x can be considered a bug too
>
> If you have any concerns about a 3.1.x update then let me know please
> today.
Hi Sergey,
definitely a good idea to clean up and separate things.
Since Swagger is an optional extension for Syncope, I would also have
the chance to adapt its CXF configuration according to the changes that
will be part of CXF 3.1.7.
Thanks for taking care of this.
Regards.
> [1] ttps://issues.apache.org/jira/browse/CXF-6760
> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
--
Francesco Chicchiricc�
Tirasa - Open Source Excellence
http://www.tirasa.net/
Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC,
CXF Committer, OpenJPA Committer, PonyMail PPMC
http://home.apache.org/~ilgrosso/
Re: Moving CXF SwaggerFeature into its own module
Posted by Francesco Chicchiriccò <il...@apache.org>.
On 04/07/2016 15:51, Sergey Beryozkin wrote:
> Hi All
>
> as part of CXF-6760 [1] I've moved the Swagger code into its own
> cxf-rt-rs-description-swagger module.
> It makes it easier for the users to choose between WADL and Swagger
> (example, right now if only WADL is preferred then no Swagger endpoint
> is there but not vice versa, having Swagger endpoint automatically
> adds a WADL filter simply because they share the same module and CXF
> tries to install WADL by default) and simplify the user dependencies
> (they'd only have to refer to this new module and not list explicitly
> swagger-jaxrs).
>
> So far it is only done on master, and would like to update 3.1.7 too -
> a minor migration issue is expected but the positive effect will be
> immediate. The fact that having a WADL filter for Swagger users is
> inevitable at 3.1.x can be considered a bug too
>
> If you have any concerns about a 3.1.x update then let me know please
> today.
Hi Sergey,
definitely a good idea to clean up and separate things.
Since Swagger is an optional extension for Syncope, I would also have
the chance to adapt its CXF configuration according to the changes that
will be part of CXF 3.1.7.
Thanks for taking care of this.
Regards.
> [1] ttps://issues.apache.org/jira/browse/CXF-6760
> [2] http://git-wip-us.apache.org/repos/asf/cxf/commit/21031e3a
--
Francesco Chicchiricc�
Tirasa - Open Source Excellence
http://www.tirasa.net/
Involved at The Apache Software Foundation:
member, Syncope PMC chair, Cocoon PMC, Olingo PMC,
CXF Committer, OpenJPA Committer, PonyMail PPMC
http://home.apache.org/~ilgrosso/