You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brian Houser (Jira)" <ji...@apache.org> on 2021/09/28 19:27:00 UTC

[jira] [Commented] (CASSANDRA-17009) Sstableverify unit test operate on SSTables

    [ https://issues.apache.org/jira/browse/CASSANDRA-17009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17421626#comment-17421626 ] 

Brian Houser commented on CASSANDRA-17009:
------------------------------------------

Added a new test which does more deeper verification {color:#b57614}StandaloneVerifierOnSSTablesTest{color}

Raises coverage an addtional 20%.


[https://github.com/apache/cassandra/pull/1231]

Did find a few minor bugs as a result of doing this, but thought it best to address them separately as this is a unit test jira.  This includes a loading error resulting in successful return code, as well as error written to stdout, as opposed to stderr.

Verified by running unit tests on desktop.

> Sstableverify unit test operate on SSTables
> -------------------------------------------
>
>                 Key: CASSANDRA-17009
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17009
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Tool/sstable
>            Reporter: Brian Houser
>            Assignee: Brian Houser
>            Priority: Normal
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> as part of https://issues.apache.org/jira/browse/CASSANDRA-16009, unit coverage is a bit lax and doesn't run through the verifier (based on my coverage results).
> There should be a unit test that exercises the internal verifier both for a corrupt example and a working example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org