[GitHub] [spark] srowen commented on a diff in pull request #43125: [SPARK-45337][CORE] Refactor `AbstractCommandBuilder#getScalaVersion` to remove the check for Scala 2.12

["srowen (via GitHub)" <gi...@apache.org>]

srowen commented on code in PR #43125:
URL: https://github.com/apache/spark/pull/43125#discussion_r1337458103


##########
launcher/src/main/java/org/apache/spark/launcher/AbstractCommandBuilder.java:
##########
@@ -230,17 +230,11 @@ String getScalaVersion() {
       return scala;
     }
     String sparkHome = getSparkHome();
-    File scala212 = new File(sparkHome, "launcher/target/scala-2.12");
     File scala213 = new File(sparkHome, "launcher/target/scala-2.13");
-    checkState(!scala212.isDirectory() || !scala213.isDirectory(),
+    checkState(!scala213.isDirectory(),

Review Comment:
   I'd comment out all this code instead, to save it in case we want to bring it back when Scala 3 is supported.
   But you just return "2.13" from this method for now unconditionally.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org