You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/11/21 21:05:54 UTC

[GitHub] [incubator-sedona] Varsha-R opened a new pull request, #717: [SEDONA-197] Added ST_ZMax and ST_ZMin to Apache Sedona

Varsha-R opened a new pull request, #717:
URL: https://github.com/apache/incubator-sedona/pull/717

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/community/develop/)
   
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the associated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-197. The PR name follows the format `[SEDONA-XXX] my subject`.
   
   
   ## What changes were proposed in this PR?
   Added ST_ZMax and ST_ZMin functions to SQL
   
   ## How was this patch tested?
   Through unit tests written in Scala
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I have updated the documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] Varsha-R commented on pull request #717: [SEDONA-197] Added ST_ZMax and ST_ZMin to Apache Sedona

Posted by GitBox <gi...@apache.org>.
Varsha-R commented on PR #717:
URL: https://github.com/apache/incubator-sedona/pull/717#issuecomment-1323082020

   > Please add the following:
   > 
   > 1. DataFrameAPI for Spark, with tests: https://github.com/apache/incubator-sedona/blob/master/sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala
   > 2. Corresponding function in Flink, with tests: https://github.com/apache/incubator-sedona/blob/master/flink/src/main/java/org/apache/sedona/flink/Catalog.java#L21
   
   Addressed these comments in [this commit](https://github.com/apache/incubator-sedona/pull/717/commits/b9fffd6ea2830350128141c548372613b658fe00#diff-42591a191598418405b17af4a87d795eb556c69b5233d699e4c106230c0e99ef) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu merged pull request #717: [SEDONA-197] Added ST_ZMax and ST_ZMin to Apache Sedona

Posted by GitBox <gi...@apache.org>.
jiayuasu merged PR #717:
URL: https://github.com/apache/incubator-sedona/pull/717


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #717: [SEDONA-197] Added ST_ZMax and ST_ZMin to Apache Sedona

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on code in PR #717:
URL: https://github.com/apache/incubator-sedona/pull/717#discussion_r1028676402


##########
docs/api/sql/Function.md:
##########
@@ -1445,3 +1445,33 @@ SELECT ST_Z(ST_POINT(0.0 25.0 11.0))
 ```
 
 Output: `11.0`
+
+## ST_ZMax
+
+Introduction: Returns Z maxima of the given geometry or null if there is no Z coordinate.
+
+Format: `ST_ZMax(geom: geometry)`
+
+Since: `v1.2.1`

Review Comment:
   the version number should be 1.3.1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] Varsha-R commented on a diff in pull request #717: [SEDONA-197] Added ST_ZMax and ST_ZMin to Apache Sedona

Posted by GitBox <gi...@apache.org>.
Varsha-R commented on code in PR #717:
URL: https://github.com/apache/incubator-sedona/pull/717#discussion_r1028836425


##########
docs/api/sql/Function.md:
##########
@@ -1445,3 +1445,33 @@ SELECT ST_Z(ST_POINT(0.0 25.0 11.0))
 ```
 
 Output: `11.0`
+
+## ST_ZMax
+
+Introduction: Returns Z maxima of the given geometry or null if there is no Z coordinate.
+
+Format: `ST_ZMax(geom: geometry)`
+
+Since: `v1.2.1`

Review Comment:
   Updated it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org