You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by lnn1123 <gi...@git.apache.org> on 2016/05/10 10:53:42 UTC

[GitHub] thrift pull request: #fix php CompactProtocol readI64 function, va...

GitHub user lnn1123 opened a pull request:

    https://github.com/apache/thrift/pull/1008

    #fix php CompactProtocol readI64 function, value=1461563457000

    php CompactProtocol readI64 function
    when value = 1461563457000, old readI64 function get wrong value 1463710940648

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lnn1123/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1008
    
----
commit 534a63bb7d5a73f24d422f64509c1460f4c3c17f
Author: lnn1123 <ln...@gmail.com>
Date:   2016-05-10T10:44:20Z

    #fix CompactProtocol readI64 function, value=1461563457000

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: #fix php CompactProtocol readI64 function, va...

Posted by lnn1123 <gi...@git.apache.org>.

Github user lnn1123 commented on the pull request:

    https://github.com/apache/thrift/pull/1008#issuecomment-219287867
  
    @nsuke OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: #fix php CompactProtocol readI64 function, va...

Posted by nsuke <gi...@git.apache.org>.

Github user nsuke commented on the pull request:

    https://github.com/apache/thrift/pull/1008#issuecomment-219226708
  
    @lnn1123 thanks for the fix !
    Could you file a JIRA issue for this ?
    https://github.com/apache/thrift/blob/master/CONTRIBUTING.md



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #1008: THRIFT-3827:php CompactProtocol readI64 function ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1008


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3827:php CompactProtocol readI64 funct...

Posted by lnn1123 <gi...@git.apache.org>.

Github user lnn1123 commented on the pull request:

    https://github.com/apache/thrift/pull/1008#issuecomment-219396868
  
    @nsuke I Make a issue, https://issues.apache.org/jira/browse/THRIFT-3827
    what to do next?  for completed pull request


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---