You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by John Dilley <jo...@citrix.com> on 2014/07/28 16:17:07 UTC
Review Request 23982: CLOUDSTACK-7192: Skip tests on Hyper-V which don't
apply
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23982/
-----------------------------------------------------------
Review request for cloudstack, sanjeev n and Santhosh Edukulla.
Bugs: CLOUDSTACK-7192
https://issues.apache.org/jira/browse/CLOUDSTACK-7192
Repository: cloudstack-git
Description
-------
A number of tests in the following files don't apply to Hyper-V. This patch means they are skipped if an attempt is made to run them.
test_nic.py
test_primary_storage.py
test_scale_vm.py
test_snapshots.py
test_vm_snapshots.py
test_volumes.py(test7 and test8 only)
Diffs
-----
test/integration/smoke/test_nic.py dd6de96
test/integration/smoke/test_primary_storage.py 66aec59
test/integration/smoke/test_scale_vm.py b5c89be
test/integration/smoke/test_snapshots.py 8b6fdd1
test/integration/smoke/test_vm_snapshots.py 01626f5
test/integration/smoke/test_volumes.py 6e9ea75
Diff: https://reviews.apache.org/r/23982/diff/
Testing
-------
Thanks,
John Dilley
Re: Review Request 23982: CLOUDSTACK-7192: Skip tests on Hyper-V which don't
apply
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23982/#review50306
-----------------------------------------------------------
Commit d75961d973021fbfec5058d907923f885ac8906a in cloudstack's branch refs/heads/master from John Dilley
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d75961d ]
CLOUDSTACK-7192: Skip tests on Hyper-V which don't apply
- ASF Subversion and Git Services
On Aug. 6, 2014, 2:41 p.m., John Dilley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23982/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 2:41 p.m.)
>
>
> Review request for cloudstack, sanjeev n and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7192
> https://issues.apache.org/jira/browse/CLOUDSTACK-7192
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> A number of tests in the following files don't apply to Hyper-V. This patch means they are skipped if an attempt is made to run them.
>
> test_nic.py
> test_primary_storage.py
> test_scale_vm.py
> test_snapshots.py
> test_vm_snapshots.py
> test_volumes.py(test7 and test8 only)
>
>
> Diffs
> -----
>
> test/integration/smoke/test_nic.py dd6de96
> test/integration/smoke/test_primary_storage.py 66aec59
> test/integration/smoke/test_scale_vm.py b5c89be
> test/integration/smoke/test_snapshots.py 8b6fdd1
> test/integration/smoke/test_vm_snapshots.py 01626f5
> test/integration/smoke/test_volumes.py 6e9ea75
>
> Diff: https://reviews.apache.org/r/23982/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John Dilley
>
>
Re: Review Request 23982: CLOUDSTACK-7192: Skip tests on Hyper-V which don't
apply
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23982/#review50307
-----------------------------------------------------------
Ship it!
Ship It!
- sanjeev n
On Aug. 6, 2014, 2:41 p.m., John Dilley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23982/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 2:41 p.m.)
>
>
> Review request for cloudstack, sanjeev n and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7192
> https://issues.apache.org/jira/browse/CLOUDSTACK-7192
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> A number of tests in the following files don't apply to Hyper-V. This patch means they are skipped if an attempt is made to run them.
>
> test_nic.py
> test_primary_storage.py
> test_scale_vm.py
> test_snapshots.py
> test_vm_snapshots.py
> test_volumes.py(test7 and test8 only)
>
>
> Diffs
> -----
>
> test/integration/smoke/test_nic.py dd6de96
> test/integration/smoke/test_primary_storage.py 66aec59
> test/integration/smoke/test_scale_vm.py b5c89be
> test/integration/smoke/test_snapshots.py 8b6fdd1
> test/integration/smoke/test_vm_snapshots.py 01626f5
> test/integration/smoke/test_volumes.py 6e9ea75
>
> Diff: https://reviews.apache.org/r/23982/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John Dilley
>
>
Re: Review Request 23982: CLOUDSTACK-7192: Skip tests on Hyper-V which don't
apply
Posted by John Dilley <jo...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23982/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 2:41 p.m.)
Review request for cloudstack, sanjeev n and Santhosh Edukulla.
Changes
-------
Where possible I've put the items in the setup method. The notable exception is the test_primary_storage.py file, because we should add an SMB primary storage test at some point, and it should go in that file.
Bugs: CLOUDSTACK-7192
https://issues.apache.org/jira/browse/CLOUDSTACK-7192
Repository: cloudstack-git
Description
-------
A number of tests in the following files don't apply to Hyper-V. This patch means they are skipped if an attempt is made to run them.
test_nic.py
test_primary_storage.py
test_scale_vm.py
test_snapshots.py
test_vm_snapshots.py
test_volumes.py(test7 and test8 only)
Diffs (updated)
-----
test/integration/smoke/test_nic.py dd6de96
test/integration/smoke/test_primary_storage.py 66aec59
test/integration/smoke/test_scale_vm.py b5c89be
test/integration/smoke/test_snapshots.py 8b6fdd1
test/integration/smoke/test_vm_snapshots.py 01626f5
test/integration/smoke/test_volumes.py 6e9ea75
Diff: https://reviews.apache.org/r/23982/diff/
Testing
-------
Thanks,
John Dilley
Re: Review Request 23982: CLOUDSTACK-7192: Skip tests on Hyper-V which don't
apply
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23982/#review49217
-----------------------------------------------------------
test/integration/smoke/test_nic.py
<https://reviews.apache.org/r/23982/#comment86104>
Instead of taking this check to inside the test case code, please move it to setup, that way atleast it is good that test code is independent upon these checks?
test/integration/smoke/test_nic.py
<https://reviews.apache.org/r/23982/#comment86105>
Another issue is does the test case does not hold for hyperv or test case code is not applicable? If test case code only, then a different addition for hyperv is required?
- Santhosh Edukulla
On July 28, 2014, 2:17 p.m., John Dilley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23982/
> -----------------------------------------------------------
>
> (Updated July 28, 2014, 2:17 p.m.)
>
>
> Review request for cloudstack, sanjeev n and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7192
> https://issues.apache.org/jira/browse/CLOUDSTACK-7192
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> A number of tests in the following files don't apply to Hyper-V. This patch means they are skipped if an attempt is made to run them.
>
> test_nic.py
> test_primary_storage.py
> test_scale_vm.py
> test_snapshots.py
> test_vm_snapshots.py
> test_volumes.py(test7 and test8 only)
>
>
> Diffs
> -----
>
> test/integration/smoke/test_nic.py dd6de96
> test/integration/smoke/test_primary_storage.py 66aec59
> test/integration/smoke/test_scale_vm.py b5c89be
> test/integration/smoke/test_snapshots.py 8b6fdd1
> test/integration/smoke/test_vm_snapshots.py 01626f5
> test/integration/smoke/test_volumes.py 6e9ea75
>
> Diff: https://reviews.apache.org/r/23982/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> John Dilley
>
>