You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2020/07/26 16:39:13 UTC

[commons-validator] branch master updated: Possible validation error

This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-validator.git


The following commit(s) were added to refs/heads/master by this push:
     new 15ee749  Possible validation error
15ee749 is described below

commit 15ee749bd505b9026830adf2e9c780097f36542b
Author: Sebb <se...@apache.org>
AuthorDate: Sun Jul 26 17:39:04 2020 +0100

    Possible validation error
---
 .../java/org/apache/commons/validator/routines/UrlValidatorTest.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java b/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
index 599dbd7..130c902 100644
--- a/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
+++ b/src/test/java/org/apache/commons/validator/routines/UrlValidatorTest.java
@@ -333,7 +333,7 @@ public class UrlValidatorTest extends TestCase {
     public void testValidator464() {
         String[] schemes = {"file"};
         UrlValidator urlValidator = new UrlValidator(schemes);
-        String fileOK = "file:///bad ^ domain.com/label/test";
+        String fileOK = "file:///bad ^ domain.com/label/test"; // TODO should '^' be allowed unescaped?
         String fileNAK = "file://bad ^ domain.com/label/test";
         assertTrue(fileOK, urlValidator.isValid(fileOK));
         assertFalse(fileNAK, urlValidator.isValid(fileNAK));