You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2015/05/12 18:42:06 UTC

Re: Review Request 30339: Use flags.hooks.isSome() before calling hooks.


> On March 4, 2015, 4:03 p.m., Niklas Nielsen wrote:
> >

Do you want this in? If so, please update the review :)


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30339/#review72824
-----------------------------------------------------------


On Jan. 27, 2015, 4:42 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30339/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2015, 4:42 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Call hook manager only if hooks were specified on the commandline.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp bda8fda9bc2e52ccc1d75e2541e4604989515e13 
>   src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 
>   src/slave/slave.cpp fca83b3977b95ddda30f9830da10e124b5c605e6 
>   src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52 
> 
> Diff: https://reviews.apache.org/r/30339/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>