You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bigtop.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2016/06/03 07:05:59 UTC

[jira] [Updated] (BIGTOP-2374) Toolchain needs clear warning for Puppet <3

     [ https://issues.apache.org/jira/browse/BIGTOP-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kengo Seki updated BIGTOP-2374:
-------------------------------
    Attachment: BIGTOP-2374.1.patch

Attaching a pacth. Tested {{./gradlew toolchain-puppetmodules}} fails on Puppet 2.7.26:

{code}
[sekikn@localhost bigtop]$ facter puppetversion                                                                                                    
2.7.26
[sekikn@localhost bigtop]$ ./gradlew toolchain-puppetmodules

(snip)

bigtop_toolchain::puppet-modules requires Puppet 3.0.0+, but found: 2.7.26 at /home/sekikn/bigtop/bigtop_toolchain/manifests/puppet-modules-prereq.pp:19 on node localhost                                                                                                           
:toolchain-puppetmodules FAILED                                                                                                            
                                                                                                                                           
FAILURE: Build failed with an exception.                                                                                                   
                                                                                                                                           
* What went wrong:                                                                                                                         
Execution failed for task ':toolchain-puppetmodules'.                                                                                      
> Process 'command 'sudo'' finished with non-zero exit value 1                                                                             
                                                                                                                                           
* Try:                                                                                                                                     
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.                             
                                                                                                                                           
BUILD FAILED                                                                                                                               
                                                                                                                                           
Total time: 10.713 secs                                                                                                                    
{code}

and succeeds on 3.3.1:

{code}
[sekikn@localhost bigtop]$ facter puppetversion                                                                                            
3.3.1
[sekikn@localhost bigtop]$ ./gradlew toolchain-puppetmodules

(snip)

BUILD SUCCESSFUL                                                                                                                           
                                                                                                                                           
Total time: 19.79 secs                                                                                                                     
                                                                                                                                           
This build could be faster, please consider using the Gradle Daemon: https://docs.gradle.org/2.7/userguide/gradle_daemon.html
[sekikn@localhost bigtop]$ ls /etc/puppet/modules/stdlib                                                                                   
CHANGELOG.md     examples  LICENSE        NOTICE                     README.markdown           spec
checksums.json   Gemfile   manifests      Rakefile                   README_SPECS.markdown
CONTRIBUTING.md  lib       metadata.json  README_DEVELOPER.markdown  RELEASE_PROCESS.markdown
{code}

> Toolchain needs clear warning for Puppet <3
> -------------------------------------------
>
>                 Key: BIGTOP-2374
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2374
>             Project: Bigtop
>          Issue Type: Bug
>          Components: toolchain
>    Affects Versions: 1.1.0
>            Reporter: Konstantin Boudnik
>             Fix For: 1.2.0
>
>         Attachments: BIGTOP-2374.1.patch
>
>
> Took me a while to figure out why puppet modules aren't getting installed. The reason is this silent fallback
> {code}
>     onlyif => "test `facter puppetversion |cut -d'.' -f 1` -ge 3",
> {code}
> in the {{bigtop_toolchain/manifests/puppet-modules.pp}}
> We need to issue a clear warning instead of falling quietly - it is a bad UX.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)