[jira] [Resolved] (HDFS-15515) mkdirs on fallback should throw IOE out instead of suppressing and returning false

["Uma Maheswara Rao G (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-15515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uma Maheswara Rao G resolved HDFS-15515.
----------------------------------------
       Fix Version/s: 3.4.0
        Hadoop Flags: Reviewed
    Target Version/s: 3.4.0
          Resolution: Fixed

> mkdirs on fallback should throw IOE out instead of suppressing and returning false
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-15515
>                 URL: https://issues.apache.org/jira/browse/HDFS-15515
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>            Priority: Major
>             Fix For: 3.4.0
>
>
> Currently when doing mkdirs on fallback dir, we catching IOE and returning false.
> I think we should just throw IOE out as the fs#mkdirs throws IOE out.
> I noticed a case when we attempt to create .reserved dirs, NN throws HadoopIAE.
> But we will catch and return false. Here exception should be thrown out.
> {code:java}
> try {
>           return linkedFallbackFs.mkdirs(dirToCreate, permission);
>         } catch (IOException e) {
>           if (LOG.isDebugEnabled()) {
>             StringBuilder msg =
>                 new StringBuilder("Failed to create ").append(dirToCreate)
>                     .append(" at fallback : ")
>                     .append(linkedFallbackFs.getUri());
>             LOG.debug(msg.toString(), e);
>           }
>           return false;
>         }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-dev-help@hadoop.apache.org