You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2026/04/01 14:58:29 UTC
[PR] SOLR-18121: Rm 'rm-in-advance' fetcher codepath [solr]
gerlowskija opened a new pull request, #4258:
URL: https://github.com/apache/solr/pull/4258
https://issues.apache.org/jira/browse/SOLR-18121
# Description
Prior to this commit, the IndexFetcher had support for an edge case where if a full-index-fetch was needed but the receiving host didn't have adequate disk space, then the IndexFetcher would delete the existing (out of date) copy of the index to free up space.
Unfortunately, this optimization/"feature" was never documented in the ref-guide, had very little test coverage, and contained a number of resource-leaks that appeared to trigger 100% of the time. While the feature might've worked when initially written, the rare-ness of the triggering condition and lack of tests had led to some severe bitrot over time.
# Solution
This commit removes the code for this optimization altogether. It largely works by walking back the code introduced in the original change, 'b061947'.
# Tests
No new tests; removal of existing test `TestReplicationHandlerDiskOverFlow`.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
- [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18121: Rm 'rm-in-advance' fetcher codepath [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #4258:
URL: https://github.com/apache/solr/pull/4258#issuecomment-4170719303
Note to self that tests and check pass on this already.
Not sure whether this merits a changelog entry or not. In theory it's a removal that folks would care about if they were relying on it. But given that it was undocumented and (afaict) 100% broken, I don't think anyone **could** rely on it. So a changelog entry would largely just be noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18121: Rm 'rm-in-advance' fetcher codepath [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on code in PR #4258:
URL: https://github.com/apache/solr/pull/4258#discussion_r3064119205
##########
changelog/unreleased/SOLR-18121-remove-delete-in-advance-optimization.yml:
##########
Review Comment:
Thanks for catching!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18121: Rm 'rm-in-advance' fetcher codepath [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on code in PR #4258:
URL: https://github.com/apache/solr/pull/4258#discussion_r3045538750
##########
changelog/unreleased/SOLR-18121-remove-delete-in-advance-optimization.yml:
##########
Review Comment:
Note: the comments need to be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18121: Rm 'rm-in-advance' fetcher codepath [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija commented on PR #4258:
URL: https://github.com/apache/solr/pull/4258#issuecomment-4198843746
> No matter how broken, the flag for it was there and some people thought it worked
What flag? There was never a feature-flag around this.
And what people thought this worked? The optimization was never documented, and flies against all of the advice we **do** have in our docs around maintaining the required disk overhead. Users would need to remember a 10 year old JIRA discussion to even have a hint that Solr attempted anything like this.
Are you sure your comment above went to the right PR @dsmiley ?
I have added a changelog entry for now, but if anything the experience has me leaning even more towards "no changelog". I've left it in case someone can word-smith a version that makes more sense. But otherwise it just feels awkward and contrived to have a changelog entry of "Removed thing that was both broken and undocumented".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-18121: Rm 'rm-in-advance' fetcher codepath [solr]
Posted by "gerlowskija (via GitHub)" <gi...@apache.org>.
gerlowskija merged PR #4258:
URL: https://github.com/apache/solr/pull/4258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org