You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "itholic (via GitHub)" <gi...@apache.org> on 2023/05/08 01:02:15 UTC

[GitHub] [spark] itholic commented on a diff in pull request #40964: [SPARK-43296][CONNECT][PYTHON] Migrate Spark Connect session errors into error class

itholic commented on code in PR #40964:
URL: https://github.com/apache/spark/pull/40964#discussion_r1186948477


##########
python/pyspark/errors/error_classes.py:
##########
@@ -536,6 +551,21 @@
       "Result vector from pandas_udf was not the required length: expected <expected>, got <actual>."
     ]
   },
+  "SESSION_OR_CONTEXT_EXISTS" : {
+    "message" : [
+      "There should not be an existing Spark Session or Spark Context."
+    ]
+  },
+  "SHOULD_NOT_DATAFRAME": {
+    "message": [
+      "Argument `<arg_name>` should not be a DataFrame."
+    ]
+  },
+  "SHOULD_NOT_DATATYPE": {
+    "message": [
+      "Argument `<arg_name>` should not be a DataType."
+    ]
+  },

Review Comment:
   Sounds good! Just applied the comment :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org