You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Jun Rao (JIRA)" <ji...@apache.org> on 2011/08/20 00:51:28 UTC

[jira] [Created] (KAFKA-113) test log4j properties shouldn't be turned off

test log4j properties shouldn't be turned off
---------------------------------------------

                 Key: KAFKA-113
                 URL: https://issues.apache.org/jira/browse/KAFKA-113
             Project: Kafka
          Issue Type: Improvement
            Reporter: Jun Rao


core/src/test/resources/log4j.properties is set to off. We should change it to error. Also, this file doesn't seem to be picked up in unit test since there are lots of info level logging in the output.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-113) test log4j properties shouldn't be turned off

Posted by "Chris Burroughs (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Burroughs updated KAFKA-113:
----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

> test log4j properties shouldn't be turned off
> ---------------------------------------------
>
>                 Key: KAFKA-113
>                 URL: https://issues.apache.org/jira/browse/KAFKA-113
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jun Rao
>            Assignee: Chris Burroughs
>             Fix For: 0.7
>
>         Attachments: k113-v1.txt
>
>
> core/src/test/resources/log4j.properties is set to off. We should change it to error. Also, this file doesn't seem to be picked up in unit test since there are lots of info level logging in the output.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (KAFKA-113) test log4j properties shouldn't be turned off

Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/KAFKA-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090507#comment-13090507 ] 

Jun Rao commented on KAFKA-113:
-------------------------------

+1. Thanks for the patch, Chris.

> test log4j properties shouldn't be turned off
> ---------------------------------------------
>
>                 Key: KAFKA-113
>                 URL: https://issues.apache.org/jira/browse/KAFKA-113
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jun Rao
>            Assignee: Chris Burroughs
>             Fix For: 0.7
>
>         Attachments: k113-v1.txt
>
>
> core/src/test/resources/log4j.properties is set to off. We should change it to error. Also, this file doesn't seem to be picked up in unit test since there are lots of info level logging in the output.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-113) test log4j properties shouldn't be turned off

Posted by "Chris Burroughs (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Burroughs updated KAFKA-113:
----------------------------------

    Fix Version/s: 0.7
         Assignee: Chris Burroughs
           Status: Patch Available  (was: Open)

> test log4j properties shouldn't be turned off
> ---------------------------------------------
>
>                 Key: KAFKA-113
>                 URL: https://issues.apache.org/jira/browse/KAFKA-113
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jun Rao
>            Assignee: Chris Burroughs
>             Fix For: 0.7
>
>         Attachments: k113-v1.txt
>
>
> core/src/test/resources/log4j.properties is set to off. We should change it to error. Also, this file doesn't seem to be picked up in unit test since there are lots of info level logging in the output.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (KAFKA-113) test log4j properties shouldn't be turned off

Posted by "Chris Burroughs (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/KAFKA-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Burroughs updated KAFKA-113:
----------------------------------

    Attachment: k113-v1.txt

- Turns logging for tests on by default
- I used WARN, that appears to result in very little output
- Adds line numbers
-  For me setting log4j.logger.kafka=TRACE results in a torrent of output.

> test log4j properties shouldn't be turned off
> ---------------------------------------------
>
>                 Key: KAFKA-113
>                 URL: https://issues.apache.org/jira/browse/KAFKA-113
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Jun Rao
>         Attachments: k113-v1.txt
>
>
> core/src/test/resources/log4j.properties is set to off. We should change it to error. Also, this file doesn't seem to be picked up in unit test since there are lots of info level logging in the output.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira