You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2023/11/10 16:27:50 UTC
[Impala-ASF-CR] IMPALA-11452: Import LLVM SectionMemoryManager for fixes
Hello Daniel Becker, Yida Wu, Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20696
to look at the new patch set (#2).
Change subject: IMPALA-11452: Import LLVM SectionMemoryManager for fixes
......................................................................
IMPALA-11452: Import LLVM SectionMemoryManager for fixes
Imports SectionMemoryManager so we can add some fixes that require
modifying private code. This could be done as a patch on LLVM, but the
memory manager seems like something we should own and may need to
customize in other ways.
Changes namespace and adds using statements to make it compile. Uses
LLVM 5.0.1 with commit 787614d08bda40daf3e168bd46a8c2a86319ec63 added as
a small security fix.
Change-Id: I8917005094903ed0ece25e40eb445abb159b569b
---
M be/src/codegen/CMakeLists.txt
A be/src/codegen/SectionMemoryManager.cc
A be/src/codegen/SectionMemoryManager.h
M be/src/codegen/mcjit-mem-mgr.h
4 files changed, 349 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/20696/2
--
To view, visit http://gerrit.cloudera.org:8080/20696
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8917005094903ed0ece25e40eb445abb159b569b
Gerrit-Change-Number: 20696
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>