You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/09/19 22:12:15 UTC
[GitHub] rob05c commented on a change in pull request #2841: ops and above
(admin) should not have any server fields masked
rob05c commented on a change in pull request #2841: ops and above (admin) should not have any server fields masked
URL: https://github.com/apache/trafficcontrol/pull/2841#discussion_r218980799
##########
File path: traffic_ops/traffic_ops_golang/server/servers.go
##########
@@ -270,7 +270,7 @@ FULL OUTER JOIN deliveryservice_server dss ON dss.server = s.id
if err = rows.StructScan(&s); err != nil {
return nil, []error{fmt.Errorf("getting servers: %v", err)}, tc.SystemError
}
- if user.PrivLevel < auth.PrivLevelAdmin {
+ if user.PrivLevel < auth.PrivLevelOperations {
Review comment:
I don't really agree with changing the API underneath people, when it's always required Admin. But I understand the difficulty of fixing the Portal to handle this.
But at the least, the documentation needs updated to match. The docs currently say
`The password of the of the lights-out-management user (displays as ** unless you are an ‘admin’ user).`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services