[GitHub] rymanluk commented on a change in pull request #197: Fix the wrong way to detect the trailing space

[GitBox <gi...@apache.org>]

rymanluk commented on a change in pull request #197: Fix the wrong way to detect the trailing space
URL: https://github.com/apache/mynewt-nimble/pull/197#discussion_r222911558
 
 

 ##########
 File path: nimble/host/mesh/src/prov.c
 ##########
 @@ -1385,6 +1385,8 @@ static void gen_prov_start(struct prov_rx *rx, struct os_mbuf *buf)
 		gen_prov_ack_send(rx->xact_id);
 		return;
 	}
+	
+	u16_t trailing_space = OS_MBUF_TRAILINGSPACE(link.rx.buf);
 
 Review comment:
   Good catch! Thanks. I have couple of comments:
   1) Please prefix commit message with "mesh:". Having this it would bring my attention much faster :)
   2) Please explain in commit message why we need this change. Comment from PR will not stay in git.
   3) Please move `trailing_space` declaration on top of the function
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services