You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/02/08 07:48:22 UTC

[GitHub] [incubator-hudi] yanghua opened a new pull request #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common

yanghua opened a new pull request #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common
URL: https://github.com/apache/incubator-hudi/pull/1314
 
 
   ## What is the purpose of the pull request
   
   *This pull request introduces a new pom module named hudi-writer-common*
   
   ## Brief change log
   
     - *Introduce a new pom module named hudi-writer-common*
   
   ## Verify this pull request
   
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] yanghua commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common
URL: https://github.com/apache/incubator-hudi/pull/1314#issuecomment-584014077
 
 
   > @yanghua ack. Do we need a feature branch for this work? can't we do this on master with incremental commits
   
   A new module will be added here. If we copy related class files from `hudi-client` to the new module instead of moving those class files. it can theoretically be completed on the master branch
   
   However, as a relatively large work (we will eventually move some classes in the `hubi-client` to other modules), it will be more reasonable to verify it on an independent branch to see whether those PRs can pass then migrate them to the master branch, which will not affect the master branch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common
URL: https://github.com/apache/incubator-hudi/pull/1314#issuecomment-583975092
 
 
   @yanghua ack. Do we need a feature branch for this work? can't we do this on master with incremental commits 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] yanghua commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common

Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common
URL: https://github.com/apache/incubator-hudi/pull/1314#issuecomment-583715237
 
 
   @vinothchandar @leesf FYI: new module `hudi-writer-common` on `restructure-hudi-client`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] vinothchandar commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common

Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common
URL: https://github.com/apache/incubator-hudi/pull/1314#issuecomment-585917397
 
 
   @yanghua as I also mentioned on the JIRA. What you suggest makes sense when we are in the phase of separating hudi-spark and hudi-writer-common.. This model also makes for us to take the hit of rebasing, without thrashing all existing PRs. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-hudi] yanghua merged pull request #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common

Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #1314: [HUDI-542] Introduce a new pom module named hudi-writer-common
URL: https://github.com/apache/incubator-hudi/pull/1314
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services