[GitHub] [incubator-iceberg] aokolnychyi commented on issue #153: [Baseline] Apply baseline linting to iceberg-core

[GitBox <gi...@apache.org>]

aokolnychyi commented on issue #153: [Baseline] Apply baseline linting to iceberg-core
URL: https://github.com/apache/incubator-iceberg/pull/153#issuecomment-491584020
 
 
   @rdblue @mccheah It is still unclear for me how we want to handle method args. For example, this PR has the following:
   
   ```
     private boolean manifestHasDeletedFiles(
         StrictMetricsEvaluator metricsEvaluator, ManifestReader reader,
         CharSequenceWrapper pathWrapper, StructLikeWrapper partitionWrapper) {
   ```
   
   I thought we stick to
   ```
     private boolean manifestHasDeletedFiles(StrictMetricsEvaluator metricsEvaluator, ManifestReader reader,
                                             CharSequenceWrapper pathWrapper, StructLikeWrapper partitionWrapper) {
   ```
   
   Both options are OK to me but we need to agree on one, I suppose.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org