[jira] [Updated] (KNOX-494) knox-env.sh script should exit with proper error message , if JAVA is not set.

["J.Andreina (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/KNOX-494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

J.Andreina updated KNOX-494:
----------------------------
    Attachment: KNOX-494.1.patch

Have attached a patch , which has changes in knox-env.sh script to exit if JAVA is not set. 

With this fix , fetching the status and cleanup of ldap and gateway server (using ldap.sh and gateway.sh script respectively ) also wont be performed if JAVA is not set. 

Please review let me know your comments. 

> knox-env.sh script should exit with proper error message , if JAVA is not set. 
> -------------------------------------------------------------------------------
>
>                 Key: KNOX-494
>                 URL: https://issues.apache.org/jira/browse/KNOX-494
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: J.Andreina
>            Assignee: J.Andreina
>         Attachments: KNOX-494.1.patch
>
>
> knox-env.sh script  does not exit when JAVA is not set .
> Hence execution of other script (which invokes knox-env.sh to set JAVA) in an environment which does not contains JAVA , continues with execution and logs non-user friendly messages as below
> {noformat}
> Execution of gateway.sh:
> nohup: invalid option -- 'j'
> Try `nohup --help' for more information.
> {noformat}
> {noformat}
> Execution of knoxcli.sh :
> ./knoxcli.sh: line 61: -jar: command not found
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)