You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/04/09 10:07:41 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #7757:
[FLINK-11630] Triggers the termination of all running Tasks when shutting
down TaskExecutor
azagrebin commented on a change in pull request #7757: [FLINK-11630] Triggers the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/7757#discussion_r273410187
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -305,8 +305,19 @@ public void start() throws Exception {
resourceManagerConnection.close();
}
+ List<CompletableFuture<Void>> cancelingTaskFutures = new ArrayList<>();
Review comment:
Could we move creation of joined tasks termination future in a separate function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services