You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sailesh Mukil (Code Review)" <ge...@cloudera.org> on 2017/04/24 21:01:49 UTC
[Impala-ASF-CR] Use appropriate transport for StatstoreSubscriber
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6720
Change subject: Use appropriate transport for StatstoreSubscriber
......................................................................
Use appropriate transport for StatstoreSubscriber
This makes sure that the appropriate Thrift transport is used in
the StatestoreSubscriber.
This patch also adds a custom cluster test to improve our security
testing.
Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
---
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
M tests/custom_cluster/test_client_ssl.py
3 files changed, 48 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/6720/1
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6720
to look at the new patch set (#3).
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
IMPALA-5253: Use appropriate transport for StatestoreSubscriber
This makes sure that the appropriate Thrift transport is used in
the StatestoreSubscriber.
This patch also adds a custom cluster test to improve our security
testing.
Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
---
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
M tests/custom_cluster/test_client_ssl.py
3 files changed, 47 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/6720/3
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/500/
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatstoreSubscriber
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatstoreSubscriber
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6720/2//COMMIT_MSG
Commit Message:
PS2, Line 7: StatstoreSubscriber
StatestoreSubscriber
http://gerrit.cloudera.org:8080/#/c/6720/1/be/src/statestore/statestore-subscriber.cc
File be/src/statestore/statestore-subscriber.cc:
Line 55:
Remove blank line
http://gerrit.cloudera.org:8080/#/c/6720/2/be/src/statestore/statestore-subscriber.cc
File be/src/statestore/statestore-subscriber.cc:
Line 54:
Remove blank line
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatstoreSubscriber
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has uploaded a new patch set (#2).
Change subject: IMPALA-5253: Use appropriate transport for StatstoreSubscriber
......................................................................
IMPALA-5253: Use appropriate transport for StatstoreSubscriber
This makes sure that the appropriate Thrift transport is used in
the StatestoreSubscriber.
This patch also adds a custom cluster test to improve our security
testing.
Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
---
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
M tests/custom_cluster/test_client_ssl.py
3 files changed, 48 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/6720/2
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 3: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/498/
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
IMPALA-5253: Use appropriate transport for StatestoreSubscriber
This makes sure that the appropriate Thrift transport is used in
the StatestoreSubscriber.
This patch also adds a custom cluster test to improve our security
testing.
Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Reviewed-on: http://gerrit.cloudera.org:8080/6720
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
2 files changed, 14 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Sailesh Mukil: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 5: Code-Review+2
> Uploaded patch set 5.
I'm removing the tests since it seems to be causing some problems on the GVO machines even though it works perfectly fine locally and on other test machines.
Since this patch needs to go in soon and limited bandwidth, I will debug the root cause of the test failures on those specific machines and add that at a later time.
Carry +2.
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6720
to look at the new patch set (#5).
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
IMPALA-5253: Use appropriate transport for StatestoreSubscriber
This makes sure that the appropriate Thrift transport is used in
the StatestoreSubscriber.
This patch also adds a custom cluster test to improve our security
testing.
Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
---
M be/src/statestore/statestore-subscriber.cc
M be/src/statestore/statestore.cc
2 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/6720/5
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 3:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/498/
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 4: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/500/
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 3:
(2 comments)
Thanks for the review Henry.
Carry +2.
http://gerrit.cloudera.org:8080/#/c/6720/2//COMMIT_MSG
Commit Message:
PS2, Line 7: StatestoreSubscribe
> StatestoreSubscriber
Done
http://gerrit.cloudera.org:8080/#/c/6720/2/be/src/statestore/statestore-subscriber.cc
File be/src/statestore/statestore-subscriber.cc:
Line 54:
> Remove blank line
Done
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 4: Code-Review+2
Looks like a flaky failure. Trying agin.
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber
......................................................................
Patch Set 5:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/512/
--
To view, visit http://gerrit.cloudera.org:8080/6720
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No