[GitHub] srowen commented on a change in pull request #23768: [SPARK-26851][SQL] Fix double-checked locking in CachedRDDBuilder

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #23768: [SPARK-26851][SQL] Fix double-checked locking in CachedRDDBuilder
URL: https://github.com/apache/spark/pull/23768#discussion_r256703310
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryRelation.scala
 ##########
 @@ -49,7 +49,7 @@ case class CachedRDDBuilder(
     storageLevel: StorageLevel,
     @transient cachedPlan: SparkPlan,
     tableName: Option[String])(
-    @transient private var _cachedColumnBuffers: RDD[CachedBatch] = null) {
+    @transient @volatile private var _cachedColumnBuffers: RDD[CachedBatch] = null) {
 
 Review comment:
   Can this just be a lazy val? I don't see any caller that specifies this argument.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org