[jira] [Commented] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

["Eric Norman (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190385#comment-17190385 ] 

Eric Norman commented on SLING-8309:
------------------------------------

FYI: I see no objections to my July comment so I opened SLING-9719 which is similar to this one but with a smaller scope where dynamic CommitHooks were not considered.

If there is consensus that dynamic CommitHooks are not a good idea then perhaps this issue should be closed and the dynamic EditorProvider support can be handled by the SLING-9719 changes?

> Allow adding CommitHooks and EditorProviders dynamically from bundles
> ---------------------------------------------------------------------
>
>                 Key: SLING-8309
>                 URL: https://issues.apache.org/jira/browse/SLING-8309
>             Project: Sling
>          Issue Type: Improvement
>          Components: Oak
>            Reporter: Sergiu Dumitriu
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, {{OakSlingRepositoryManager}} uses a hard-coded list of {{CommitHook}} and {{EditorProvider}} to be used by the Oak repository. This means that other than building a patched version of {{OakSlingRepositoryManager}} there's no way to include a new commit observer. Ideally, a single pseudo-\{{CommitHook}} and pseudo-\{{EditorProvider}} should be handled to Oak, and these should just dynamically aggregate all the {{CommitHook}} and {{EditorProvider}} instances registered in the {{Whiteboard}}.
> All the currently hardcoded components are already available in the whiteboard, so no functionality will be lost, but this change will automatically enable support for {{mix:atomicCounter}} via the {{AtomicCounterEditorProvider}} that's not used at the moment.
> The old behavior should still be available via a new configuration, {{OakSlingRepositoryManagerConfiguration#dynamic_components}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)