You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/03/25 03:38:05 UTC

[GitHub] [ozone] ChenSammi commented on pull request #1992: HDDS-4901. Remove OmOzoneAclMap from OmVolumeArgs to avoid OzoneAcl c…

ChenSammi commented on pull request #1992:
URL: https://github.com/apache/ozone/pull/1992#issuecomment-806339915


   @xiaoyuyao , thanks for consolidating native ACL logics. The patch overall looks good. 
   
   Besides some inline comments,  there is "TestOmOzoneAclMap.java".  
   This UT is introduced in HDDS-4606, which fixed the issue that duplicate default ACLs are added on volume.  I don't find existing UT which covers this case.  So can you refine the TestOmOzoneAclMap.java to keep it, or add a new duplicate default ACL check UT somewhere in existing test class? 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org