[jira] [Commented] (OMID-114) Prevent extra RPCs on TTable batch operations

["Yonatan Gottesman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OMID-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634376#comment-16634376 ] 

Yonatan Gottesman commented on OMID-114:
----------------------------------------

looks good.

1 small question: Why in the case of deletes we check deleteP.isEmpty() but we dont do it for puts?

> Prevent extra RPCs on TTable batch operations
> ---------------------------------------------
>
>                 Key: OMID-114
>                 URL: https://issues.apache.org/jira/browse/OMID-114
>             Project: Apache Omid
>          Issue Type: Sub-task
>            Reporter: James Taylor
>            Priority: Major
>         Attachments: OMID-114.patch, OMID-114_v2.patch
>
>
> We're doing an RPC for every item in batch operations on these TTable method:
>  * put(Transaction transaction, List<Put> puts)
>  * delete(Transaction transaction, List<Delete> deletes)
>  * batch(Transaction transaction, List<? extends Row> rows)
> Instead, we can do a single RPC when the rows are sent to HBase.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)