You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/03/25 02:47:45 UTC

Review Request: Moved slave::Framework/Executor implementation into slave.cpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10112/
-----------------------------------------------------------

Review request for mesos.


Description
-------

As slave::Framework/Executor grows, it makes a lot of sense to move them into slave.cpp.


Diffs
-----

  src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 
  src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7 

Diff: https://reviews.apache.org/r/10112/diff/


Testing
-------


Thanks,

Benjamin Hindman


Re: Review Request: Moved slave::Framework/Executor implementation into slave.cpp.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10112/#review18343
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On March 25, 2013, 1:47 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10112/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 1:47 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Description
> -------
> 
> As slave::Framework/Executor grows, it makes a lot of sense to move them into slave.cpp.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 
>   src/slave/slave.cpp 091ec5ed19924aef31b761e68b70b8d042f9a9b7 
> 
> Diff: https://reviews.apache.org/r/10112/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>