You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2013/12/04 01:58:04 UTC
Review Request 15981: [HELIX-327] Simplify rebalancer,
rename rebalancer configs, support settable contexts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15981/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-327
Repository: helix-git
Description
-------
commit 173de5e2d6ace577429eb16192020560440c42bb
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Tue Dec 3 16:52:23 2013 -0800
[HELIX-327] Simplify rebalancer, rename rebalancer configs, support settable contexts
:100644 100644 ebd7a35... 2af63a5... M helix-core/src/main/java/org/apache/helix/PropertyKey.java
:100644 100644 60a92f4... d66e7d9... M helix-core/src/main/java/org/apache/helix/PropertyPathConfig.java
:100644 100644 680dc06... 75adb20... M helix-core/src/main/java/org/apache/helix/PropertyType.java
:100644 100644 fdeb879... 98072d1... M helix-core/src/main/java/org/apache/helix/api/Cluster.java
:100644 100644 79a1e09... 0726510... M helix-core/src/main/java/org/apache/helix/api/Resource.java
:100644 100644 6d69981... cda83d8... M helix-core/src/main/java/org/apache/helix/api/accessor/AtomicResourceAccessor.java
:100644 100644 b01a3ec... 36c7aaa... M helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java
:100644 100644 2721d91... c3deafe... M helix-core/src/main/java/org/apache/helix/api/accessor/ParticipantAccessor.java
:100644 100644 e5ac57c... b308b98... M helix-core/src/main/java/org/apache/helix/api/accessor/ResourceAccessor.java
:100644 100644 38d48ab... b148a49... M helix-core/src/main/java/org/apache/helix/api/config/ResourceConfig.java
:000000 100644 0000000... 29a72b7... A helix-core/src/main/java/org/apache/helix/api/id/ContextId.java
:100644 100644 eec745e... 96be0fa... M helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
:000000 100644 0000000... 2d98347... A helix-core/src/main/java/org/apache/helix/controller/context/BasicControllerContext.java
:000000 100644 0000000... b1be5c2... A helix-core/src/main/java/org/apache/helix/controller/context/ControllerContext.java
:000000 100644 0000000... 8c1d03a... A helix-core/src/main/java/org/apache/helix/controller/context/ControllerContextHolder.java
:000000 100644 0000000... 1541585... A helix-core/src/main/java/org/apache/helix/controller/context/ControllerContextProvider.java
:100644 100644 5209e2c... 6629bec... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java
:100644 100644 fc4bfa0... 3aa41d7... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/FallbackRebalancer.java
:100644 100644 6d7b0ef... 0c55d45... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/FullAutoRebalancer.java
:100644 100644 7fcbba5... 1fbb02f... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/HelixRebalancer.java
:100644 100644 a0ad6f3... 51ca463... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/SemiAutoRebalancer.java
:000000 100644 0000000... d6aa10e... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/BasicRebalancerConfig.java
:000000 100644 0000000... 73c3ccc... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/CustomRebalancerConfig.java
:000000 100644 0000000... 828d509... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/FullAutoRebalancerConfig.java
:000000 100644 0000000... 2c9769d... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/PartitionedRebalancerConfig.java
:000000 100644 0000000... 3f8c9d1... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/RebalancerConfig.java
:000000 100644 0000000... 8581732... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/RebalancerConfigHolder.java
:000000 100644 0000000... 3118b2a... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/ReplicatedRebalancerConfig.java
:000000 100644 0000000... bfc3309... A helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/SemiAutoRebalancerConfig.java
:100644 000000 ec765d7... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/BasicRebalancerContext.java
:100644 000000 ef12a09... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/ContextSerializer.java
:100644 000000 0d2c1f2... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/CustomRebalancerContext.java
:100644 000000 ecc93fb... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/DefaultContextSerializer.java
:100644 000000 2400707... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/FullAutoRebalancerContext.java
:100644 000000 15fcf9c... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/PartitionedRebalancerContext.java
:100644 000000 aa872c4... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/RebalancerConfig.java
:100644 000000 981891b... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/RebalancerContext.java
:100644 000000 525931d... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/ReplicatedRebalancerContext.java
:100644 000000 afa81e2... 0000000... D helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/SemiAutoRebalancerContext.java
:000000 100644 0000000... d612451... A helix-core/src/main/java/org/apache/helix/controller/serializer/DefaultStringSerializer.java
:000000 100644 0000000... 9311191... A helix-core/src/main/java/org/apache/helix/controller/serializer/StringSerializer.java
:100644 100644 ae0278b... 5cedd7c... M helix-core/src/main/java/org/apache/helix/controller/stages/AttributeName.java
:100644 100644 7b143bd... ec812b2... M helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
:100644 100644 edceed6... 7704378... M helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
:100644 100644 08e6799... ef5a5fd... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java
:100644 100644 bbbf5c6... 9adc833... M helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java
:100644 100644 31dbb08... 45fc355... M helix-core/src/main/java/org/apache/helix/controller/stages/PersistAssignmentStage.java
:000000 100644 0000000... e63041a... A helix-core/src/main/java/org/apache/helix/controller/stages/PersistContextStage.java
:100644 100644 44fddb6... fb016f1... M helix-core/src/main/java/org/apache/helix/controller/stages/ReadClusterDataStage.java
:100644 100644 1fdd892... 5b75535... M helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java
:100644 100644 f32649f... 8c5b863... M helix-core/src/main/java/org/apache/helix/model/ResourceConfiguration.java
:100644 100644 98f7cac... ba8958d... M helix-core/src/main/java/org/apache/helix/tools/NewClusterSetup.java
:100644 100644 0d597f6... ab4ead0... M helix-core/src/test/java/org/apache/helix/api/TestNewStages.java
:100644 100644 74781cd... 3c8fb2c... M helix-core/src/test/java/org/apache/helix/api/TestUpdateConfig.java
:100644 100644 5bbe54f... 94deaac... M helix-core/src/test/java/org/apache/helix/controller/rebalancer/context/TestSerializeRebalancerContext.java
:100644 100644 e53530c... 22c4168... M helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java
:100644 100644 e320011... 90ea393... M helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java
:100644 100644 ce26e2e... 11805fe... M helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java
:100644 100644 29e0a44... b415393... M helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java
:100644 100644 c233417... 880d31c... M helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java
:100644 100644 ff98cd2... 3693c2b... M recipes/user-defined-rebalancer/src/main/java/org/apache/helix/userdefinedrebalancer/LockManagerRebalancer.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/PropertyKey.java ebd7a35
helix-core/src/main/java/org/apache/helix/PropertyPathConfig.java 60a92f4
helix-core/src/main/java/org/apache/helix/PropertyType.java 680dc06
helix-core/src/main/java/org/apache/helix/api/Cluster.java fdeb879
helix-core/src/main/java/org/apache/helix/api/Resource.java 79a1e09
helix-core/src/main/java/org/apache/helix/api/accessor/AtomicResourceAccessor.java 6d69981
helix-core/src/main/java/org/apache/helix/api/accessor/ClusterAccessor.java b01a3ec
helix-core/src/main/java/org/apache/helix/api/accessor/ParticipantAccessor.java 2721d91
helix-core/src/main/java/org/apache/helix/api/accessor/ResourceAccessor.java e5ac57c
helix-core/src/main/java/org/apache/helix/api/config/ResourceConfig.java 38d48ab
helix-core/src/main/java/org/apache/helix/api/id/ContextId.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java eec745e
helix-core/src/main/java/org/apache/helix/controller/context/BasicControllerContext.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/context/ControllerContext.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/context/ControllerContextHolder.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/context/ControllerContextProvider.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java 5209e2c
helix-core/src/main/java/org/apache/helix/controller/rebalancer/FallbackRebalancer.java fc4bfa0
helix-core/src/main/java/org/apache/helix/controller/rebalancer/FullAutoRebalancer.java 6d7b0ef
helix-core/src/main/java/org/apache/helix/controller/rebalancer/HelixRebalancer.java 7fcbba5
helix-core/src/main/java/org/apache/helix/controller/rebalancer/SemiAutoRebalancer.java a0ad6f3
helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/BasicRebalancerConfig.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/CustomRebalancerConfig.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/FullAutoRebalancerConfig.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/PartitionedRebalancerConfig.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/RebalancerConfig.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/RebalancerConfigHolder.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/ReplicatedRebalancerConfig.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/config/SemiAutoRebalancerConfig.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/BasicRebalancerContext.java ec765d7
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/ContextSerializer.java ef12a09
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/CustomRebalancerContext.java 0d2c1f2
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/DefaultContextSerializer.java ecc93fb
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/FullAutoRebalancerContext.java 2400707
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/PartitionedRebalancerContext.java 15fcf9c
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/RebalancerConfig.java aa872c4
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/RebalancerContext.java 981891b
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/ReplicatedRebalancerContext.java 525931d
helix-core/src/main/java/org/apache/helix/controller/rebalancer/context/SemiAutoRebalancerContext.java afa81e2
helix-core/src/main/java/org/apache/helix/controller/serializer/DefaultStringSerializer.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/serializer/StringSerializer.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/stages/AttributeName.java ae0278b
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java 7b143bd
helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java edceed6
helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationStage.java 08e6799
helix-core/src/main/java/org/apache/helix/controller/stages/MessageSelectionStage.java bbbf5c6
helix-core/src/main/java/org/apache/helix/controller/stages/PersistAssignmentStage.java 31dbb08
helix-core/src/main/java/org/apache/helix/controller/stages/PersistContextStage.java PRE-CREATION
helix-core/src/main/java/org/apache/helix/controller/stages/ReadClusterDataStage.java 44fddb6
helix-core/src/main/java/org/apache/helix/controller/stages/ResourceComputationStage.java 1fdd892
helix-core/src/main/java/org/apache/helix/model/ResourceConfiguration.java f32649f
helix-core/src/main/java/org/apache/helix/tools/NewClusterSetup.java 98f7cac
helix-core/src/test/java/org/apache/helix/api/TestNewStages.java 0d597f6
helix-core/src/test/java/org/apache/helix/api/TestUpdateConfig.java 74781cd
helix-core/src/test/java/org/apache/helix/controller/rebalancer/context/TestSerializeRebalancerContext.java 5bbe54f
helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java e53530c
helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java e320011
helix-core/src/test/java/org/apache/helix/integration/TestCustomizedIdealStateRebalancer.java ce26e2e
helix-core/src/test/java/org/apache/helix/integration/TestHelixConnection.java 29e0a44
helix-examples/src/main/java/org/apache/helix/examples/LogicalModelExample.java c233417
recipes/user-defined-rebalancer/src/main/java/org/apache/helix/userdefinedrebalancer/LockManagerRebalancer.java ff98cd2
Diff: https://reviews.apache.org/r/15981/diff/
Testing
-------
Existing tests pass locally, new test case added to user-defined rebalancer test also passes.
Thanks,
Kanak Biscuitwala