You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ivy-commits@incubator.apache.org by gs...@apache.org on 2007/06/23 22:49:18 UTC

svn commit: r550134 - in /incubator/ivy/core/trunk: src/java/org/apache/ivy/plugins/parser/AbstractModuleDescriptorParser.java test/java/org/apache/ivy/plugins/latest/LatestRevisionStrategyTest.java

Author: gscokart
Date: Sat Jun 23 15:49:17 2007
New Revision: 550134

URL: http://svn.apache.org/viewvc?view=rev&rev=550134
Log:
clean code

Modified:
    incubator/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/AbstractModuleDescriptorParser.java
    incubator/ivy/core/trunk/test/java/org/apache/ivy/plugins/latest/LatestRevisionStrategyTest.java

Modified: incubator/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/AbstractModuleDescriptorParser.java
URL: http://svn.apache.org/viewvc/incubator/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/AbstractModuleDescriptorParser.java?view=diff&rev=550134&r1=550133&r2=550134
==============================================================================
--- incubator/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/AbstractModuleDescriptorParser.java (original)
+++ incubator/ivy/core/trunk/src/java/org/apache/ivy/plugins/parser/AbstractModuleDescriptorParser.java Sat Jun 23 15:49:17 2007
@@ -43,7 +43,8 @@
 public abstract class AbstractModuleDescriptorParser implements ModuleDescriptorParser {
     public ModuleDescriptor parseDescriptor(IvySettings ivySettings, URL descriptorURL,
             boolean validate) throws ParseException, IOException {
-        return parseDescriptor(ivySettings, descriptorURL, new URLResource(descriptorURL), validate);
+        return parseDescriptor(ivySettings, descriptorURL, 
+            new URLResource(descriptorURL), validate);
     }
 
     protected abstract static class AbstractParser extends DefaultHandler {
@@ -307,8 +308,9 @@
             String systemId = ex.getSystemId();
             if (systemId != null) {
                 int index = systemId.lastIndexOf('/');
-                if (index != -1)
+                if (index != -1) {
                     systemId = systemId.substring(index + 1);
+                }
                 str.append(systemId);
             } else if (getResource() != null) {
                 str.append(getResource().toString());

Modified: incubator/ivy/core/trunk/test/java/org/apache/ivy/plugins/latest/LatestRevisionStrategyTest.java
URL: http://svn.apache.org/viewvc/incubator/ivy/core/trunk/test/java/org/apache/ivy/plugins/latest/LatestRevisionStrategyTest.java?view=diff&rev=550134&r1=550133&r2=550134
==============================================================================
--- incubator/ivy/core/trunk/test/java/org/apache/ivy/plugins/latest/LatestRevisionStrategyTest.java (original)
+++ incubator/ivy/core/trunk/test/java/org/apache/ivy/plugins/latest/LatestRevisionStrategyTest.java Sat Jun 23 15:49:17 2007
@@ -68,7 +68,7 @@
 
     public void testSpecialMeaningComparator() {
         ArtifactInfo[] revs = toMockAI(new String[] {"0.1", "0.2-pre", "0.2-dev", "0.2-rc1",
-                "0.2-final", "0.2-QA", "1.0-dev1",});
+                "0.2-final", "0.2-QA", "1.0-dev1"});
 
         List shuffled = new ArrayList(Arrays.asList(revs));
         Collections.shuffle(shuffled);