You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Doğacan Güney (JIRA)" <ji...@apache.org> on 2009/01/29 20:39:59 UTC

[jira] Created: (HADOOP-5142) MapWritable#putAll does not store classes

MapWritable#putAll does not store classes
-----------------------------------------

                 Key: HADOOP-5142
                 URL: https://issues.apache.org/jira/browse/HADOOP-5142
             Project: Hadoop Core
          Issue Type: Bug
          Components: io
            Reporter: Doğacan Güney
            Priority: Minor


MapWritable's putAll method does not call addToMap for keys and values as MapWritable#put does. So new classes will not be stored
in class-id maps and will lead to problems during readFields.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5142) MapWritable#putAll does not store classes

Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682273#action_12682273 ] 

Enis Soztutar commented on HADOOP-5142:
---------------------------------------

Yes, I have reviewed and tested the code before committing. 

> MapWritable#putAll does not store classes
> -----------------------------------------
>
>                 Key: HADOOP-5142
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5142
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Doğacan Güney
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: mapwritableputall.patch
>
>
> MapWritable's putAll method does not call addToMap for keys and values as MapWritable#put does. So new classes will not be stored
> in class-id maps and will lead to problems during readFields.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5142) MapWritable#putAll does not store classes

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675922#action_12675922 ] 

Hudson commented on HADOOP-5142:
--------------------------------

Integrated in Hadoop-trunk #763 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/763/])
    . Fix MapWritable#putAll to store key/value classes. Contributed by Doğacan Güney.


> MapWritable#putAll does not store classes
> -----------------------------------------
>
>                 Key: HADOOP-5142
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5142
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Doğacan Güney
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: mapwritableputall.patch
>
>
> MapWritable's putAll method does not call addToMap for keys and values as MapWritable#put does. So new classes will not be stored
> in class-id maps and will lead to problems during readFields.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HADOOP-5142) MapWritable#putAll does not store classes

Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681972#action_12681972 ] 

Tsz Wo (Nicholas), SZE commented on HADOOP-5142:
------------------------------------------------

Hi, did the patch got tested or reviewed?

> MapWritable#putAll does not store classes
> -----------------------------------------
>
>                 Key: HADOOP-5142
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5142
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Doğacan Güney
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: mapwritableputall.patch
>
>
> MapWritable's putAll method does not call addToMap for keys and values as MapWritable#put does. So new classes will not be stored
> in class-id maps and will lead to problems during readFields.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5142) MapWritable#putAll does not store classes

Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doğacan Güney updated HADOOP-5142:
----------------------------------

    Attachment: mapwritableputall.patch

Simple patch that just calls put method.

I haven't tested this patch but I think it should work.

> MapWritable#putAll does not store classes
> -----------------------------------------
>
>                 Key: HADOOP-5142
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5142
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Doğacan Güney
>            Priority: Minor
>         Attachments: mapwritableputall.patch
>
>
> MapWritable's putAll method does not call addToMap for keys and values as MapWritable#put does. So new classes will not be stored
> in class-id maps and will lead to problems during readFields.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HADOOP-5142) MapWritable#putAll does not store classes

Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Enis Soztutar resolved HADOOP-5142.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.20.0
     Release Note: Fix MapWritable#putAll to store key/value classes.
     Hadoop Flags: [Reviewed]

I committed this in 0.20. Thanks Doğacan. 

> MapWritable#putAll does not store classes
> -----------------------------------------
>
>                 Key: HADOOP-5142
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5142
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Doğacan Güney
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: mapwritableputall.patch
>
>
> MapWritable's putAll method does not call addToMap for keys and values as MapWritable#put does. So new classes will not be stored
> in class-id maps and will lead to problems during readFields.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HADOOP-5142) MapWritable#putAll does not store classes

Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Chansler updated HADOOP-5142:
------------------------------------

    Release Note:   (was: Fix MapWritable#putAll to store key/value classes.)

> MapWritable#putAll does not store classes
> -----------------------------------------
>
>                 Key: HADOOP-5142
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5142
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: io
>            Reporter: Doğacan Güney
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: mapwritableputall.patch
>
>
> MapWritable's putAll method does not call addToMap for keys and values as MapWritable#put does. So new classes will not be stored
> in class-id maps and will lead to problems during readFields.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.