You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@griffin.apache.org by William GUO <gu...@outlook.com> on 2017/06/30 15:24:00 UTC

[VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Dear IPMC,

This is a call for a vote on releasing Apache Griffin 0.1.5-incubating, release candidate 1. This is the first release of Griffin.

Apache Griffin is data quality solution for modern data system, it defines a standard process to define, measure data quality for well-known dimensions. With Apache Griffin, users will be able to quickly define their data quality requirements and then get the result in near real time in systematical approach.

PPMC vote threads:
https://lists.apache.org/thread.html/3cf8200cc6c8f2c0f4f411e994d80a79c5f1592d7883d30a99ca0bbf@%3Cdev.griffin.apache.org%3E

PPMC vote result threads:
https://lists.apache.org/thread.html/9f9bba113fd914cf2571ca905c27227510b685a3e3325e314fd0898b@%3Cdev.griffin.apache.org%3E


We have cleaned up bundled software for license issues.
https://github.com/apache/incubator-griffin/blob/master/LICENSE.md


  The source tarball, including signatures, digests, etc. can be found at:
  https://dist.apache.org/repos/dist/dev/incubator/griffin/0.1.5-incubating


  The tag to be voted upon is 0.1.5-incubating:
  https://git-wip-us.apache.org/repos/asf?p=incubator-griffin.git;a=shortlog;h=refs/tags/0.1.5-incubating


  The release hash is f1ad4b7b6390b988f3625df3eba652a7fb59ad68:
  https://git-wip-us.apache.org/repos/asf?p=incubator-griffin.git;a=commit;h=8bb45e94e9c8a94b51f5d5ed12866ca87668d863

  The Nexus Staging URL:
  https://repository.apache.org/content/repositories/orgapachegriffin-1003


  Release artifacts are signed with the following key:
  https://dist.apache.org/repos/dist/dev/incubator/griffin/KEYS

  KEYS file available:
  https://dist.apache.org/repos/dist/dev/incubator/griffin/KEYS


  For information about the contents of this release, see:
  https://dist.apache.org/repos/dist/dev/incubator/griffin/0.1.5-incubating/CHANGES.txt


  Please vote on releasing this package as Apache Griffin 0.1.5-incubating

  The vote will be open for 72 hours.

  [ ] +1 Release this package as Apache Griffin ${RELEASE_VERSION}-incubating
  [ ] +0 no opinion
  [ ] -1 Do not release this package because ...


Thanks,
Apache Griffin Team

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by William Guo <gu...@apache.org>.

--sorry, use my Apache account and sent it again.


Hi Justin,

Thanks a lot for your checking.

Ok, we will strictly follow license name to make it as License.

We made big change since we bundled some 3rd party sources in our artifacts before, which was not right,
so, we remove those JavaScript files(toaster, charts, etc).
Those dependencies, declared in bower.js, will be installed when deploying in user box.

We are not good at license issue, what is your advice for following two cases?

1 Not sure where this is right way to handle those JavaScript dependencies license issue as above.
2 How to handle background.jpg?

Will remove asf header in treeview.js.

Will file a ticket for this license thread.


William

________________________________
From: William GUO <gu...@outlook.com>
Sent: Tuesday, July 4, 2017 12:09:15 PM
To: general@incubator.apache.org
Cc: dev@griffin.incubator.apache.org
Subject: Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Hi Justin,

Thanks a lot for your checking.

Ok, we will strictly follow license name to make it as License.

We made big change since we bundled some 3rd party sources in our artifacts before, which was not right,
so, we remove those JavaScript files(toaster, charts, etc).
Those dependencies, declared in bower.js, will be installed when deploying in user box.

We are not good at license issue, what is your advice for following two cases?

1 Not sure where this is right way to handle those JavaScript dependencies license issue as above.
2 How to handle background.jpg?

Will remove asf header in treeview.js.

Will file a ticket for this license thread.


William

On 7/4/17, 9:55 AM, "Justin Mclean" <ju...@classsoftware.com> wrote:

    Hi,

    Sorry  -1 as the LICENSE file has not been fixed from last RC. The LICENSE file needs to be called LICENSE or LICENSE.txt and contain all 3rd party bundled licenses. [1][2] I’ll consider changing my vote if other IPMC members vote +1 on this and it fixed in the next release.

    I can see that LICENSE doesn’t contain any mention of 3rd party bundled code and that they are instead mentioned in LICENSE.md.

    I can see that LICENSE.md refers to 3rd party software that is no longer bundled in this RC i.e. angular toaster, charts, font awesome etc ect

    In fact it seems just about all 3rd party software has been removed except for [4] which incorrectly has an ASF header and is MIT licensed. Why the big change from last time? IS there any reason all this 3rd party software is no longer required?

    I checked:
    - name includes incubating
    - signature and hashes good
    - LICENSE has issues (see above)
    - NOTICE is good
    - no unexpected binary
    - source files have ASF headers
    - don’t check compile form source due to complex requirements/setup

    There are a couple of unresolved issues from the last RC - including for instance who own copyright on this file? [3] Has a JIRA been raised to sort these out?

    Thanks,
    Justin

    1. http://www.apache.org/dev/apply-license.html#license-file-name
    2. http://www.apache.org/legal/release-policy.html#license-file
    3.  ./ui/login/background.jpg
    4. ./ui/js/directives/treeview.js
    ---------------------------------------------------------------------
    To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
    For additional commands, e-mail: general-help@incubator.apache.org

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by William Guo <gu...@apache.org>.

--sorry, use my Apache account and sent it again.


Hi Justin,

Thanks a lot for your checking.

Ok, we will strictly follow license name to make it as License.

We made big change since we bundled some 3rd party sources in our artifacts before, which was not right,
so, we remove those JavaScript files(toaster, charts, etc).
Those dependencies, declared in bower.js, will be installed when deploying in user box.

We are not good at license issue, what is your advice for following two cases?

1 Not sure where this is right way to handle those JavaScript dependencies license issue as above.
2 How to handle background.jpg?

Will remove asf header in treeview.js.

Will file a ticket for this license thread.


William

________________________________
From: William GUO <gu...@outlook.com>
Sent: Tuesday, July 4, 2017 12:09:15 PM
To: general@incubator.apache.org
Cc: dev@griffin.incubator.apache.org
Subject: Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Hi Justin,

Thanks a lot for your checking.

Ok, we will strictly follow license name to make it as License.

We made big change since we bundled some 3rd party sources in our artifacts before, which was not right,
so, we remove those JavaScript files(toaster, charts, etc).
Those dependencies, declared in bower.js, will be installed when deploying in user box.

We are not good at license issue, what is your advice for following two cases?

1 Not sure where this is right way to handle those JavaScript dependencies license issue as above.
2 How to handle background.jpg?

Will remove asf header in treeview.js.

Will file a ticket for this license thread.


William

On 7/4/17, 9:55 AM, "Justin Mclean" <ju...@classsoftware.com> wrote:

    Hi,

    Sorry  -1 as the LICENSE file has not been fixed from last RC. The LICENSE file needs to be called LICENSE or LICENSE.txt and contain all 3rd party bundled licenses. [1][2] I’ll consider changing my vote if other IPMC members vote +1 on this and it fixed in the next release.

    I can see that LICENSE doesn’t contain any mention of 3rd party bundled code and that they are instead mentioned in LICENSE.md.

    I can see that LICENSE.md refers to 3rd party software that is no longer bundled in this RC i.e. angular toaster, charts, font awesome etc ect

    In fact it seems just about all 3rd party software has been removed except for [4] which incorrectly has an ASF header and is MIT licensed. Why the big change from last time? IS there any reason all this 3rd party software is no longer required?

    I checked:
    - name includes incubating
    - signature and hashes good
    - LICENSE has issues (see above)
    - NOTICE is good
    - no unexpected binary
    - source files have ASF headers
    - don’t check compile form source due to complex requirements/setup

    There are a couple of unresolved issues from the last RC - including for instance who own copyright on this file? [3] Has a JIRA been raised to sort these out?

    Thanks,
    Justin

    1. http://www.apache.org/dev/apply-license.html#license-file-name
    2. http://www.apache.org/legal/release-policy.html#license-file
    3.  ./ui/login/background.jpg
    4. ./ui/js/directives/treeview.js
    ---------------------------------------------------------------------
    To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
    For additional commands, e-mail: general-help@incubator.apache.org

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by William Guo <gu...@apache.org>.

hi  Justin,


We will cancel this thread and make another RC2 to fix license issue.

Thanks,
William
________________________________
From: Justin Mclean <ju...@classsoftware.com>
Sent: Wednesday, July 5, 2017 6:24:05 AM
To: general@incubator.apache.org
Subject: Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Hi,

While this vote is still open there’s no real need to make another RC - it may still get 3 +1 votes.

But up to the PMC if they want to cancel this and make another RC.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

While this vote is still open there’s no real need to make another RC - it may still get 3 +1 votes.

But up to the PMC if they want to cancel this and make another RC.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by William GUO <gu...@outlook.com>.

hi Luke,


We will generate another release candidate for vote to fix those issues.



Thanks,

William

________________________________
From: Luke Han <lu...@gmail.com>
Sent: Tuesday, July 4, 2017 10:01:20 PM
To: general@incubator.apache.org
Subject: Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

But for release, should you guys generate another tar file for vote, if you
removed such files today?




Best Regards!
---------------------

Luke Han

On Tue, Jul 4, 2017 at 1:59 PM, Justin Mclean <ju...@classsoftware.com>
wrote:

> Hi,
>
> Changing my vote to +1 binding.
>
> Looks like everything is being sorted, the only real issue with this
> release (other than confusing licensing information) is that it's missing a
> single MIT licensed piece of software in LICENSE.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by Luke Han <lu...@gmail.com>.

But for release, should you guys generate another tar file for vote, if you
removed such files today?




Best Regards!
---------------------

Luke Han

On Tue, Jul 4, 2017 at 1:59 PM, Justin Mclean <ju...@classsoftware.com>
wrote:

> Hi,
>
> Changing my vote to +1 binding.
>
> Looks like everything is being sorted, the only real issue with this
> release (other than confusing licensing information) is that it's missing a
> single MIT licensed piece of software in LICENSE.
>
> Thanks,
> Justin
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

Changing my vote to +1 binding.

Looks like everything is being sorted, the only real issue with this release (other than confusing licensing information) is that it's missing a single MIT licensed piece of software in LICENSE.

Thanks,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by William Guo <gu...@apache.org>.

hi Justin,


> You also need to ask those some question about the test data files pointed out in the last RC.


We have removed  demo-purposed test data files, just keep sample data for unit tests.



Thanks,

William

________________________________
From: Justin Mclean <ju...@classsoftware.com>
Sent: Tuesday, July 4, 2017 12:23:41 PM
To: general@incubator.apache.org
Subject: Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Hi,

> We made big change since we bundled some 3rd party sources in our artifacts before, which was not right,
> so, we remove those JavaScript files(toaster, charts, etc).

It fine to bundle things as long as the ASF license policy is followed.

> We are not good at license issue, what is your advice for following two cases?

Your mentors should be able to help you here but I’ll answer as well.

> 1 Not sure where this is right way to handle those JavaScript dependencies license issue as above.

You need to add tree view MIT license info to the LICENSE file if it is bundled. [1] I would just remove LICENSE.md as it’s not correct and it easier to keep one file up to date than two but that’s up to you.

> 2 How to handle background.jpg?

In order to know that you need to find answers to the following. Where did the file come from? Who owns the copyright on it and how is it licensed? Do you have permission to use and distribute it?

You also need to ask those some question about the test data files pointed out in the last RC.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

> We made big change since we bundled some 3rd party sources in our artifacts before, which was not right, 
> so, we remove those JavaScript files(toaster, charts, etc).

It fine to bundle things as long as the ASF license policy is followed.

> We are not good at license issue, what is your advice for following two cases?

Your mentors should be able to help you here but I’ll answer as well.

> 1 Not sure where this is right way to handle those JavaScript dependencies license issue as above.

You need to add tree view MIT license info to the LICENSE file if it is bundled. [1] I would just remove LICENSE.md as it’s not correct and it easier to keep one file up to date than two but that’s up to you.

> 2 How to handle background.jpg?

In order to know that you need to find answers to the following. Where did the file come from? Who owns the copyright on it and how is it licensed? Do you have permission to use and distribute it?

You also need to ask those some question about the test data files pointed out in the last RC.

Thanks,
Justin

1. http://www.apache.org/dev/licensing-howto.html#permissive-deps
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by William GUO <gu...@outlook.com>.

Hi Justin,

Thanks a lot for your checking.

Ok, we will strictly follow license name to make it as License.

We made big change since we bundled some 3rd party sources in our artifacts before, which was not right,
so, we remove those JavaScript files(toaster, charts, etc).
Those dependencies, declared in bower.js, will be installed when deploying in user box.

We are not good at license issue, what is your advice for following two cases?

1 Not sure where this is right way to handle those JavaScript dependencies license issue as above.
2 How to handle background.jpg?

Will remove asf header in treeview.js.

Will file a ticket for this license thread.

William

On 7/4/17, 9:55 AM, "Justin Mclean" <ju...@classsoftware.com> wrote:

Hi,

Sorry -1 as the LICENSE file has not been fixed from last RC. The LICENSE file needs to be called LICENSE or LICENSE.txt and contain all 3rd party bundled licenses. [1][2] I’ll consider changing my vote if other IPMC members vote +1 on this and it fixed in the next release.

I can see that LICENSE doesn’t contain any mention of 3rd party bundled code and that they are instead mentioned in LICENSE.md.

I can see that LICENSE.md refers to 3rd party software that is no longer bundled in this RC i.e. angular toaster, charts, font awesome etc ect

In fact it seems just about all 3rd party software has been removed except for [4] which incorrectly has an ASF header and is MIT licensed. Why the big change from last time? IS there any reason all this 3rd party software is no longer required?

I checked:
- name includes incubating
- signature and hashes good
- LICENSE has issues (see above)
- NOTICE is good
- no unexpected binary
- source files have ASF headers
- don’t check compile form source due to complex requirements/setup

There are a couple of unresolved issues from the last RC - including for instance who own copyright on this file? [3] Has a JIRA been raised to sort these out?

Thanks,
Justin

1. http://www.apache.org/dev/apply-license.html#license-file-name
2. http://www.apache.org/legal/release-policy.html#license-file
3. ./ui/login/background.jpg
4. ./ui/js/directives/treeview.js
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by William GUO <gu...@outlook.com>.

Hi Justin,

Thanks a lot for your checking.

Ok, we will strictly follow license name to make it as License.

We are not good at license issue, what is your advice for following two cases?

1 Not sure where this is right way to handle those JavaScript dependencies license issue as above.
2 How to handle background.jpg?

Will remove asf header in treeview.js.

Will file a ticket for this license thread.

William

On 7/4/17, 9:55 AM, "Justin Mclean" <ju...@classsoftware.com> wrote:

Hi,

I can see that LICENSE doesn’t contain any mention of 3rd party bundled code and that they are instead mentioned in LICENSE.md.

I can see that LICENSE.md refers to 3rd party software that is no longer bundled in this RC i.e. angular toaster, charts, font awesome etc ect

There are a couple of unresolved issues from the last RC - including for instance who own copyright on this file? [3] Has a JIRA been raised to sort these out?

Thanks,
Justin

Fw: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by William Guo <gu...@apache.org>.

we need to handle this.

________________________________
From: Justin Mclean <ju...@classsoftware.com>
Sent: Tuesday, July 4, 2017 9:55 AM
To: general@incubator.apache.org
Subject: Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Hi,

Sorry  -1 as the LICENSE file has not been fixed from last RC. The LICENSE file needs to be called LICENSE or LICENSE.txt and contain all 3rd party bundled licenses. [1][2] I’ll consider changing my vote if other IPMC members vote +1 on this and it fixed in the next release.

I can see that LICENSE doesn’t contain any mention of 3rd party bundled code and that they are instead mentioned in LICENSE.md.

I can see that LICENSE.md refers to 3rd party software that is no longer bundled in this RC i.e. angular toaster, charts, font awesome etc ect

In fact it seems just about all 3rd party software has been removed except for [4] which incorrectly has an ASF header and is MIT licensed. Why the big change from last time? IS there any reason all this 3rd party software is no longer required?

I checked:
- name includes incubating
- signature and hashes good
- LICENSE has issues (see above)
- NOTICE is good
- no unexpected binary
- source files have ASF headers
- don’t check compile form source due to complex requirements/setup

There are a couple of unresolved issues from the last RC - including for instance who own copyright on this file? [3] Has a JIRA been raised to sort these out?

Thanks,
Justin

1. http://www.apache.org/dev/apply-license.html#license-file-name
Applying the Apache License, Version 2.0<http://www.apache.org/dev/apply-license.html#license-file-name>
www.apache.org
Contents¶ Understanding the 2.0 license¶ The ALv2 is this set of self-documented copyright and patent licensing terms. The license terms are written in such a way ...

2. http://www.apache.org/legal/release-policy.html#license-file
Release Policy - Apache Software Foundation<http://www.apache.org/legal/release-policy.html#license-file>
www.apache.org
Release Policy¶ Definition of "release"¶ Generically, a release is anything that is published beyond the group that owns it. For an Apache project, that means any ...

3.  ./ui/login/background.jpg
4. ./ui/js/directives/treeview.js
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org

Re: [VOTE] Release of Apache Griffin 0.1.5-incubating [rc1]

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

I can see that LICENSE doesn’t contain any mention of 3rd party bundled code and that they are instead mentioned in LICENSE.md.

I can see that LICENSE.md refers to 3rd party software that is no longer bundled in this RC i.e. angular toaster, charts, font awesome etc ect

There are a couple of unresolved issues from the last RC - including for instance who own copyright on this file? [3] Has a JIRA been raised to sort these out?

Thanks,
Justin