You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rodent of Unusual Size <Ke...@Golux.Com> on 2002/01/21 21:10:36 UTC
Re: Tagging 1.3.23
Bill Stoddard wrote:
>
> Tagged.
Breakage:
CC="gcc" \
CFLAGS="-g -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow " \
./configure --enable-shared=max --enable-module=most
:
make
:
gcc -c -I../../os/unix -I../../include -DLINUX=22 -DNO_DBM_REWRITEMAP -DUSE_HSREGEX -DUSE_EXPAT -I../../lib/expat-lite -g
-O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow `../../apaci` -fpic -DSHARED_MODULE mod_auth_dbm.c && mv
mod_auth_dbm.o mod_auth_dbm.lo
mod_auth_dbm.c:84:18: ndbm.h: No such file or directory
make[4]: *** [mod_auth_dbm.so] Error 1
make[3]: *** [all] Error 1
make[2]: *** [subdirs] Error 1
make[2]: Leaving directory `/home/coar/apache-1.3/src'
make[1]: *** [build-std] Error 2
make[1]: Leaving directory `/home/coar/apache-1.3'
make: *** [build] Error 2
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"Millenium hand and shrimp!"
Re: Tagging 1.3.23
Posted by Thomas Eibner <th...@stderr.net>.
On Mon, Jan 21, 2002 at 03:53:31PM -0500, Rodent of Unusual Size wrote:
> "Victor J. Orlikowski" wrote:
> >
> > Argh!!!!
> > Not this *again*.
> > *Sigh*.
> > Which linux distribution?
>
> RH 7.1. This was building for 1.3.22, so I'm pretty sure
> this is something new.
I just tried it on my debian, with the ndbm.h symbolic link it works,
without it breaks. So I'd say it's a linux problem. It's been happening
to me for ages on my new debian boxen until I did the link from gdbm-ndbm.h
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: Tagging 1.3.23
Posted by Thomas Eibner <th...@stderr.net>.
On Mon, Jan 21, 2002 at 05:04:01PM -0500, Rodent of Unusual Size wrote:
> Thomas Eibner wrote:
> >
> > Moving around on the way that find-dbm-lib looks for the libs works for
> > me on my Debian box. Is this going to break something else?
>
> Without testing this patch (my 7.1 system just hung again),
> wouldn't we have to fix the CFLAGS to include "-I/usr/include/gdbm",
> though?
Your machine didn't have the db1 files? Why don't we just add another
test with the gdbm headers then? Need a patch?
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: Tagging 1.3.23
Posted by "Victor J. Orlikowski" <vj...@dulug.duke.edu>.
I still think that there has to be a better way, rather than patching
find-dbm-lib right and left based on wherever a vendor decided to put
their ndbm.h.
If no-one beats me to it, I'll prolly muck with this tonight.
Victor
--
Victor J. Orlikowski | The Wall is Down, But the Threat Remains!
==================================================================
orlikowski@apache.org | vjo@dulug.duke.edu | vjo@us.ibm.com
Re: Tagging 1.3.23
Posted by Jim Jagielski <ji...@jaguNET.com>.
At 2:40 PM -0500 1/22/02, Victor J. Orlikowski wrote:
>Cool. Jim or Bill, ball's in your court.
>
I'll let Bill take it, unless he wants/needs a break :)
--
===========================================================================
Jim Jagielski [|] jim@jaguNET.com [|] http://www.jaguNET.com/
"A society that will trade a little liberty for a little order
will lose both and deserve neither"
Re: Tagging 1.3.23
Posted by "Victor J. Orlikowski" <vj...@dulug.duke.edu>.
Credit where credit's due. Thomas' patch.
Victor
--
Victor J. Orlikowski | The Wall is Down, But the Threat Remains!
==================================================================
orlikowski@apache.org | vjo@dulug.duke.edu | vjo@us.ibm.com
Re: Tagging 1.3.23
Posted by Bill Stoddard <bi...@wstoddard.com>.
> Since the initial tag of 1.3.23, other than Victor's fix, there have only been
> OtherBill's symbol patches. I'd like to propose this course of action
> (by the by, I've talked this over with BillS and he's asked me to
> step in as RM).
>
> 1. We abide by a short (12-24hour) code freeze on the current 1.3 tree.
> 2. We test the current CVS tree.
> 3. If all is good, then at noon (Eastern) tomorrow, I'll force-retag
> 1.3.23 (with the required changes to match the fact that we're
> 1.3.23).
>
> The other option was to pull down the 1.3.23 tag, apply Victor's patch, and
> then retag that, but there's some question about the completeness of
> the 1.3.23 tags. So I'd feel a little more comfortable with a redo.
>
> Acceptable
We do not need a retag of the entire release. Victor can move the tag on his one change;
Bill Rowe can move the tags on his files, then roll the tarball as normal. This can be
completed in a few minutes.
Bill
Re: Tagging 1.3.23
Posted by Jim Jagielski <ji...@jaguNET.com>.
Since the initial tag of 1.3.23, other than Victor's fix, there have only been
OtherBill's symbol patches. I'd like to propose this course of action
(by the by, I've talked this over with BillS and he's asked me to
step in as RM).
1. We abide by a short (12-24hour) code freeze on the current 1.3 tree.
2. We test the current CVS tree.
3. If all is good, then at noon (Eastern) tomorrow, I'll force-retag
1.3.23 (with the required changes to match the fact that we're
1.3.23).
The other option was to pull down the 1.3.23 tag, apply Victor's patch, and
then retag that, but there's some question about the completeness of
the 1.3.23 tags. So I'd feel a little more comfortable with a redo.
Acceptable?
--
===========================================================================
Jim Jagielski [|] jim@jaguNET.com [|] http://www.jaguNET.com/
"A society that will trade a little liberty for a little order
will lose both and deserve neither"
Re: Tagging 1.3.23
Posted by "Victor J. Orlikowski" <vj...@dulug.duke.edu>.
Cool. Jim or Bill, ball's in your court.
Victor
--
Victor J. Orlikowski | The Wall is Down, But the Threat Remains!
==================================================================
orlikowski@apache.org | vjo@dulug.duke.edu | vjo@us.ibm.com
Re: Tagging 1.3.23
Posted by Greg Ames <gr...@remulak.net>.
"Victor J. Orlikowski" wrote:
> If nobody screams within the next 2 hours, I'll move the tag onto the
> current find-dbm-lib.
ummm, it would probably be better if you let the RM do that so he can stay on
top of the delta from the original tag.
Greg
Re: Tagging 1.3.23
Posted by "Victor J. Orlikowski" <vj...@dulug.duke.edu>.
O.K. ...
So, the current script works.
If nobody screams within the next 2 hours, I'll move the tag onto the
current find-dbm-lib.
find-dbm-lib does its best, it would seem, considering all the
different db libraries, plus where all the vendors choose to locate
them.
Victor
--
Victor J. Orlikowski | The Wall is Down, But the Threat Remains!
==================================================================
orlikowski@apache.org | vjo@dulug.duke.edu | vjo@us.ibm.com
Re: Tagging 1.3.23
Posted by Thomas Eibner <th...@stderr.net>.
On Tue, Jan 22, 2002 at 02:36:31AM -0500, Victor J. Orlikowski wrote:
> Hrm.....Gave things a second look.
>
> Thomas, I think your fix is fine. I will commit it shortly.
>
> I think, however, that a more reliable option with the various Linux
> distributions may be to use the DBM_LIB variable a little more in
> src/Configure. If we can determine the linux distribution being used,
> we could simply set DBM_LIB as needed, and simplify find-dbm-lib down
> to the default case.
>
> On RedHat, I know that version info is kept in /etc/redhat-release.
> Is there something similar on other distributions (I ask about Debian
> in particular, as I am rather ignorant of its setup)?
/etc/debian_version, but I'm not sure any dbm headers are included by
default in debian, I'll have to install a vmware test box later tonight.
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: Tagging 1.3.23
Posted by "Victor J. Orlikowski" <vj...@dulug.duke.edu>.
Hrm.....Gave things a second look.
Thomas, I think your fix is fine. I will commit it shortly.
I think, however, that a more reliable option with the various Linux
distributions may be to use the DBM_LIB variable a little more in
src/Configure. If we can determine the linux distribution being used,
we could simply set DBM_LIB as needed, and simplify find-dbm-lib down
to the default case.
On RedHat, I know that version info is kept in /etc/redhat-release.
Is there something similar on other distributions (I ask about Debian
in particular, as I am rather ignorant of its setup)?
Victor
--
Victor J. Orlikowski | The Wall is Down, But the Threat Remains!
==================================================================
orlikowski@apache.org | vjo@dulug.duke.edu | vjo@us.ibm.com
Re: Tagging 1.3.23
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Thomas Eibner wrote:
>
> Like this? I had to put the gdbm test after db1 since debian only has
> the gdbm-ndbm.h (but it has the db1/ndbm.h)
Yep, that does it -- at least on the RH 7.1 system; haven't
tried it on others. -Wall -Wmissing-prototypes generates a
bunch o' messages for ndbm.h, but the server builds.
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"Millenium hand and shrimp!"
Re: Tagging 1.3.23
Posted by Thomas Eibner <th...@stderr.net>.
On Mon, Jan 21, 2002 at 05:04:01PM -0500, Rodent of Unusual Size wrote:
> Thomas Eibner wrote:
> >
> > Moving around on the way that find-dbm-lib looks for the libs works for
> > me on my Debian box. Is this going to break something else?
>
> Without testing this patch (my 7.1 system just hung again),
> wouldn't we have to fix the CFLAGS to include "-I/usr/include/gdbm",
> though?
Like this? I had to put the gdbm test after db1 since debian only has
the gdbm-ndbm.h (but it has the db1/ndbm.h)
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: Tagging 1.3.23
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Thomas Eibner wrote:
>
> Moving around on the way that find-dbm-lib looks for the libs works for
> me on my Debian box. Is this going to break something else?
Without testing this patch (my 7.1 system just hung again),
wouldn't we have to fix the CFLAGS to include "-I/usr/include/gdbm",
though?
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"Millenium hand and shrimp!"
Re: Tagging 1.3.23
Posted by Thomas Eibner <th...@stderr.net>.
On Mon, Jan 21, 2002 at 04:10:49PM -0500, Victor J. Orlikowski wrote:
> Problem found, but not resolved.
>
> Turns out that find-dbm-lib in helpers looks for ndbm.h in
> /usr/include/db1 on RH 7. This is provided in the db1-devel package.
> However, gdbm-devel also provides a ndbm.h, in /usr/include/gdbm.
>
> The problem at hand:
> We are going to have users who want to use mod_auth_dbm, and wonder
> why ndbm.h can't be found on their system when it's there, plain as
> day.
>
> 2 solutions:
> 1) Doc it up. Does the job, but not what I want.
> 2) Fix find-dbm-lib properly, so that it does "The Right Thing" and
> uses whatever dbm it finds.
>
> I prefer 2, but is it the right thing for 1.3.23 (I would hope that
> thsi would not scrap it)?
>
> Issues:
> Are there any GNU licensing issues with linking against gdbm? If so,
> solution 1 will do for now, since we will have to force the user to
> install db1-devel. However, find-dbm-lib has always felt like
> something of a hack to me.
Moving around on the way that find-dbm-lib looks for the libs works for
me on my Debian box. Is this going to break something else?
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: Tagging 1.3.23
Posted by "Victor J. Orlikowski" <vj...@dulug.duke.edu>.
Problem found, but not resolved.
Turns out that find-dbm-lib in helpers looks for ndbm.h in
/usr/include/db1 on RH 7. This is provided in the db1-devel package.
However, gdbm-devel also provides a ndbm.h, in /usr/include/gdbm.
The problem at hand:
We are going to have users who want to use mod_auth_dbm, and wonder
why ndbm.h can't be found on their system when it's there, plain as
day.
2 solutions:
1) Doc it up. Does the job, but not what I want.
2) Fix find-dbm-lib properly, so that it does "The Right Thing" and
uses whatever dbm it finds.
I prefer 2, but is it the right thing for 1.3.23 (I would hope that
thsi would not scrap it)?
Issues:
Are there any GNU licensing issues with linking against gdbm? If so,
solution 1 will do for now, since we will have to force the user to
install db1-devel. However, find-dbm-lib has always felt like
something of a hack to me.
Victor
--
Victor J. Orlikowski | The Wall is Down, But the Threat Remains!
==================================================================
orlikowski@apache.org | vjo@dulug.duke.edu | vjo@us.ibm.com
Re: Tagging 1.3.23
Posted by Jim Jagielski <ji...@jaguNET.com>.
At 1:54 PM +0100 1/23/02, Martin Kraemer wrote:
>On Tue, Jan 22, 2002 at 10:10:14AM -0500, Bill Stoddard wrote:
>> > +1 on retaging... if Greg's "interpretation" is correct and we just retag
>> > with the same tag. I was confused by what we meant by "bump" :) :)
>>
>> "bump" is "move" in this context. You can use the command
>>
>> cvs tag -r yadda APACHE_1_3_23 file.c
>
>or tag *everything* (uh oh, also httpd.h!) by using...
>
> cvs tag -F APACHE_1_3_23 .
>
My export of the APACHE_1_3_23 tree included httpd.h... In fact, it looks
complete now (since I tagged the htdocs as well this am). I'm doing a
final check now, and will be rolling within an hour.
--
===========================================================================
Jim Jagielski [|] jim@jaguNET.com [|] http://www.jaguNET.com/
"A society that will trade a little liberty for a little order
will lose both and deserve neither"
Re: Tagging 1.3.23
Posted by Martin Kraemer <Ma...@Fujitsu-Siemens.com>.
On Tue, Jan 22, 2002 at 10:10:14AM -0500, Bill Stoddard wrote:
> > +1 on retaging... if Greg's "interpretation" is correct and we just retag
> > with the same tag. I was confused by what we meant by "bump" :) :)
>
> "bump" is "move" in this context. You can use the command
>
> cvs tag -r yadda APACHE_1_3_23 file.c
or tag *everything* (uh oh, also httpd.h!) by using...
cvs tag -F APACHE_1_3_23 .
Martin
--
<Ma...@Fujitsu-Siemens.com> | Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730 Munich, Germany
Re: Tagging 1.3.23
Posted by Bill Stoddard <bi...@wstoddard.com>.
> +1 on retaging... if Greg's "interpretation" is correct and we just retag
> with the same tag. I was confused by what we meant by "bump" :) :)
"bump" is "move" in this context. You can use the command
cvs tag -r yadda APACHE_1_3_23 file.c
to move the APACHE_1_3_23 tag to a version 'yadda' of file.c. Or alternately, remove the
tag from the file then retag at HEAD...
cvs rtag -d APACHE_1_3_23 file.c
cvs tag APACHE_1_3_23 file.c
There may be yet better ways to move the tag.
Moving tags is not normally a good thing to do, but if we just need to move tags for just
a few files to fix narrowly scoped problems, then, IMHO, it is an acceptable thing to do
in lieu of retagging the entire release.
Bill
Re: Tagging 1.3.23
Posted by Jim Jagielski <ji...@jaguNET.com>.
+1 on retaging... if Greg's "interpretation" is correct and we just retag
with the same tag. I was confused by what we meant by "bump" :) :)
--
===========================================================================
Jim Jagielski [|] jim@jaguNET.com [|] http://www.jaguNET.com/
"A society that will trade a little liberty for a little order
will lose both and deserve neither"
Re: Tagging 1.3.23
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
"Victor J. Orlikowski" wrote:
>
> Argh!!!!
> Not this *again*.
> *Sigh*.
> Which linux distribution?
RH 7.1. This was building for 1.3.22, so I'm pretty sure
this is something new.
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"Millenium hand and shrimp!"
Re: Tagging 1.3.23
Posted by "Victor J. Orlikowski" <vj...@dulug.duke.edu>.
Argh!!!!
Not this *again*.
*Sigh*.
Which linux distribution?
Victor
--
Victor J. Orlikowski | The Wall is Down, But the Threat Remains!
==================================================================
orlikowski@apache.org | vjo@dulug.duke.edu | vjo@us.ibm.com
Re: Tagging 1.3.23
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Joe Orton wrote:
>
> This will happen if you don't have the db1-devel package installed
> (unsurprisingly: if the header isn't there, it isn't detected). If you
> do have db1-devel installed, you should find -I/usr/include/db1 in your
> CFLAGS...
So what's the /usr/include/gdbm/ndbm.h file all about, then?
Meseems we should be more friendly about this at APACI ./configure
time, and removing mod_auth_dbm from the build list, rather than
horking on the 'missing' header file and aborting the make. As far
as that goes, don't we have a means for modules to hook into
the ./configure process so they can complain if they're missing
prerequisites?
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"Millenium hand and shrimp!"
Re: Tagging 1.3.23
Posted by Joe Orton <jo...@redhat.com>.
On Mon, Jan 21, 2002 at 03:10:36PM -0500, Ken Coar wrote:
> :
> gcc -c -I../../os/unix -I../../include -DLINUX=22 -DNO_DBM_REWRITEMAP -DUSE_HSREGEX -DUSE_EXPAT -I../../lib/expat-lite -g
> -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow `../../apaci` -fpic -DSHARED_MODULE mod_auth_dbm.c && mv
> mod_auth_dbm.o mod_auth_dbm.lo
> mod_auth_dbm.c:84:18: ndbm.h: No such file or directory
This will happen if you don't have the db1-devel package installed
(unsurprisingly: if the header isn't there, it isn't detected). If you
do have db1-devel installed, you should find -I/usr/include/db1 in your
CFLAGS...
joe
Re: Tagging 1.3.23
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Thomas Eibner wrote:
>
> On Mon, Jan 21, 2002 at 04:15:25PM -0500, Rodent of Unusual Size wrote:
> >
> > A /usr/include/gdbm/ndbm.h file exists. Adding symbolic
> > links all over the /usr/include tree is *not* an option if
> > other packages don't have a problem with finding it.
>
> But you're not including <gdbm/ndbm.h>. You're including <ndbm.h> in the
> module.
I as a user am not doing either. I am just building Apache.
If it's including the wrong file (wrong because there *is*
an ndbm.h file in the include tree), it's not *my* fault
but Apache's. Apache needs to include the correct file, not
require me to put symbolic links all over my filesystem.
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"Millenium hand and shrimp!"
Re: Tagging 1.3.23
Posted by Thomas Eibner <th...@stderr.net>.
On Mon, Jan 21, 2002 at 04:15:25PM -0500, Rodent of Unusual Size wrote:
> Thomas Eibner wrote:
> >
> > ln -s /usr/include/gdbm-ndbm.h /usr/include/ndbm.h in case
> > you're running debian and have installed libgdbmg1-dev.
> > (If that is the case: debian breakage by default, not apache's fault)
>
> A /usr/include/gdbm/ndbm.h file exists. Adding symbolic
> links all over the /usr/include tree is *not* an option if
> other packages don't have a problem with finding it.
But you're not including <gdbm/ndbm.h>. You're including <ndbm.h> in the
module.
And having -I/usr/include/gdbm sounds just as bad as linking with gdbm-ndbmh
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>
Re: Tagging 1.3.23
Posted by Rodent of Unusual Size <Ke...@Golux.Com>.
Thomas Eibner wrote:
>
> ln -s /usr/include/gdbm-ndbm.h /usr/include/ndbm.h in case
> you're running debian and have installed libgdbmg1-dev.
> (If that is the case: debian breakage by default, not apache's fault)
A /usr/include/gdbm/ndbm.h file exists. Adding symbolic
links all over the /usr/include tree is *not* an option if
other packages don't have a problem with finding it.
--
#ken P-)}
Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/
Author, developer, opinionist http://Apache-Server.Com/
"Millenium hand and shrimp!"
Re: Tagging 1.3.23
Posted by Thomas Eibner <th...@stderr.net>.
On Mon, Jan 21, 2002 at 03:10:36PM -0500, Rodent of Unusual Size wrote:
> Bill Stoddard wrote:
> >
> > Tagged.
>
> Breakage:
>
> CC="gcc" \
> CFLAGS="-g -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow " \
> ./configure --enable-shared=max --enable-module=most
> :
> make
> :
> gcc -c -I../../os/unix -I../../include -DLINUX=22 -DNO_DBM_REWRITEMAP -DUSE_HSREGEX -DUSE_EXPAT -I../../lib/expat-lite -g
> -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow `../../apaci` -fpic -DSHARED_MODULE mod_auth_dbm.c && mv
> mod_auth_dbm.o mod_auth_dbm.lo
> mod_auth_dbm.c:84:18: ndbm.h: No such file or directory
> make[4]: *** [mod_auth_dbm.so] Error 1
> make[3]: *** [all] Error 1
> make[2]: *** [subdirs] Error 1
> make[2]: Leaving directory `/home/coar/apache-1.3/src'
> make[1]: *** [build-std] Error 2
> make[1]: Leaving directory `/home/coar/apache-1.3'
> make: *** [build] Error 2
ln -s /usr/include/gdbm-ndbm.h /usr/include/ndbm.h in case you're running
debian and have installed libgdbmg1-dev.
(If that is the case: debian breakage by default, not apache's fault)
--
Thomas Eibner <http://thomas.eibner.dk/> DnsZone <http://dnszone.org/>
mod_pointer <http://stderr.net/mod_pointer>