You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/14 08:43:59 UTC
[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1983: fix: only auth type plugin need to configure in consumer
LiteSun opened a new pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
only auth type plugin need to configure in consumer
**Related issues**
resolve #1975
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #1983: fix: only auth type plugin need to configure in consumer
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983#issuecomment-879725346
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1983?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1983](https://codecov.io/gh/apache/apisix-dashboard/pull/1983?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a291fc3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1e55aa3d531e6cbe5ca90c1dd0d2bfc56bfe1506?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e55aa3) will **not change** coverage.
> The diff coverage is `100.00%`.
> :exclamation: Current head a291fc3 differs from pull request most recent head dec528c. Consider uploading reports for the commit dec528c to get more accurate results
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1983 +/- ##
=======================================
Coverage 64.01% 64.01%
=======================================
Files 122 122
Lines 3154 3154
Branches 753 753
=======================================
Hits 2019 2019
Misses 1135 1135
```
| Flag | Coverage Δ | |
|---|---|---|
| frontend-e2e-test | `64.01% <100.00%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1983?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [web/src/components/Plugin/service.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9zZXJ2aWNlLnRz) | `96.15% <ø> (ø)` | |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1983/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.60% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1983?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1983?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1e55aa3...dec528c](https://codecov.io/gh/apache/apisix-dashboard/pull/1983?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1983: fix: only auth type plugin need to configure in consumer
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983#issuecomment-879712088
:heavy_check_mark: Deploy Preview for *apisix-dashboard* ready!
:hammer: Explore the source changes: dec528ca96b8d0fc4f3c82f30b1a04939a23ba29
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60eea3c1785ba5000895d50d](https://app.netlify.com/sites/apisix-dashboard/deploys/60eea3c1785ba5000895d50d?utm_source=github&utm_campaign=bot_dl)
:sunglasses: Browse the preview: [https://deploy-preview-1983--apisix-dashboard.netlify.app/](https://deploy-preview-1983--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1983: fix: only auth type plugin need to configure
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1983: fix: only auth type plugin need to configure
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983#discussion_r671005397
##########
File path: web/src/components/Plugin/service.ts
##########
@@ -34,6 +34,7 @@ export const fetchList = () => {
const typedData = data.data.map(item => ({
...item,
type: PLUGIN_LIST[item.name]?.type || "other",
Review comment:
> Does type props still be used? If not we can delete it ^^
Type props still are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun merged pull request #1983: fix: only auth type plugin need to configure
Posted by GitBox <gi...@apache.org>.
LiteSun merged pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1983: fix: only auth type plugin need to configure
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983#discussion_r670931472
##########
File path: web/src/components/Plugin/service.ts
##########
@@ -34,6 +34,7 @@ export const fetchList = () => {
const typedData = data.data.map(item => ({
...item,
type: PLUGIN_LIST[item.name]?.type || "other",
Review comment:
Does `type` props still be used? If not we can delete it ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1983: fix: only auth type plugin need to configure in consumer
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983#issuecomment-879712088
:construction_worker: Deploy Preview for *apisix-dashboard* processing.
:hammer: Explore the source changes: dec528ca96b8d0fc4f3c82f30b1a04939a23ba29
:mag: Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60eea3c1785ba5000895d50d](https://app.netlify.com/sites/apisix-dashboard/deploys/60eea3c1785ba5000895d50d?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1983: fix: only auth type plugin need to configure
Posted by GitBox <gi...@apache.org>.
liuxiran commented on a change in pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983#discussion_r670931472
##########
File path: web/src/components/Plugin/service.ts
##########
@@ -34,6 +34,7 @@ export const fetchList = () => {
const typedData = data.data.map(item => ({
...item,
type: PLUGIN_LIST[item.name]?.type || "other",
Review comment:
Does `type` props still be used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1983: fix: only auth type plugin need to configure
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983#discussion_r670965603
##########
File path: web/src/components/Plugin/service.ts
##########
@@ -34,6 +34,7 @@ export const fetchList = () => {
const typedData = data.data.map(item => ({
...item,
type: PLUGIN_LIST[item.name]?.type || "other",
Review comment:
need @LiteSun to have a search
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org