You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Yong Qiao Wang <yq...@cn.ibm.com> on 2015/09/02 15:13:20 UTC
Review Request 38051: Only update the task status when its old status
is not terminal.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-2864
https://issues.apache.org/jira/browse/MESOS-2864
Repository: mesos
Description
-------
Only update the task status when its old status is not terminal.
Diffs
-----
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
Diff: https://reviews.apache.org/r/38051/diff/
Testing
-------
Thanks,
Yong Qiao Wang
Re: Review Request 38051: Only update the task status when its old
status is not terminal.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review97866
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38051]
All tests passed.
- Mesos ReviewBot
On Sept. 5, 2015, 1:38 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2015, 1:38 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only update the task status when its old status is not terminal.
>
>
> Diffs
> -----
>
> src/master/master.cpp 5589eca
>
> Diff: https://reviews.apache.org/r/38051/diff/
>
>
> Testing
> -------
>
> UT:
>
> 1. make successfully!
> 2. make check successfully!
> 3. Run test framework successfully!
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 38051: Only update the task status when its old
status is not terminal.
Posted by Yong Qiao Wang <yq...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/
-----------------------------------------------------------
(Updated 九月 5, 2015, 1:38 p.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-2864
https://issues.apache.org/jira/browse/MESOS-2864
Repository: mesos
Description
-------
Only update the task status when its old status is not terminal.
Diffs (updated)
-----
src/master/master.cpp 5589eca
Diff: https://reviews.apache.org/r/38051/diff/
Testing (updated)
-------
UT:
1. make successfully!
2. make check successfully!
3. Run test framework successfully!
Thanks,
Yong Qiao Wang
Re: Review Request 38051: Only update the task status when its old
status is not terminal.
Posted by Vinod Kone <vi...@gmail.com>.
> On Sept. 4, 2015, 7:42 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 4118
> > <https://reviews.apache.org/r/38051/diff/1/?file=1062262#file1062262line4118>
> >
> > Instead of not calling updateTask() the logic should be inside updateTask() to do the right thing. Note that updateTask() already has logic to deal with duplicate terminal updates.
Also, needs a test!
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review97790
-----------------------------------------------------------
On Sept. 2, 2015, 1:13 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 1:13 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only update the task status when its old status is not terminal.
>
>
> Diffs
> -----
>
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
>
> Diff: https://reviews.apache.org/r/38051/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 38051: Only update the task status when its old
status is not terminal.
Posted by Yong Qiao Wang <yq...@cn.ibm.com>.
> On 九月 4, 2015, 7:42 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 4118
> > <https://reviews.apache.org/r/38051/diff/1/?file=1062262#file1062262line4118>
> >
> > Instead of not calling updateTask() the logic should be inside updateTask() to do the right thing. Note that updateTask() already has logic to deal with duplicate terminal updates.
>
> Vinod Kone wrote:
> Also, needs a test!
Thanks a billion for your many times review. I have updated the changes by your usful comments.
- Yong Qiao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review97790
-----------------------------------------------------------
On 九月 2, 2015, 1:13 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> -----------------------------------------------------------
>
> (Updated 九月 2, 2015, 1:13 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only update the task status when its old status is not terminal.
>
>
> Diffs
> -----
>
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
>
> Diff: https://reviews.apache.org/r/38051/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 38051: Only update the task status when its old
status is not terminal.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review97790
-----------------------------------------------------------
src/master/master.cpp (line 4118)
<https://reviews.apache.org/r/38051/#comment153805>
Instead of not calling updateTask() the logic should be inside updateTask() to do the right thing. Note that updateTask() already has logic to deal with duplicate terminal updates.
- Vinod Kone
On Sept. 2, 2015, 1:13 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 1:13 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only update the task status when its old status is not terminal.
>
>
> Diffs
> -----
>
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
>
> Diff: https://reviews.apache.org/r/38051/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yong Qiao Wang
>
>
Re: Review Request 38051: Only update the task status when its old
status is not terminal.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review97447
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38051]
All tests passed.
- Mesos ReviewBot
On Sept. 2, 2015, 1:13 p.m., Yong Qiao Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 1:13 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-2864
> https://issues.apache.org/jira/browse/MESOS-2864
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Only update the task status when its old status is not terminal.
>
>
> Diffs
> -----
>
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
>
> Diff: https://reviews.apache.org/r/38051/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yong Qiao Wang
>
>