You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/11/20 17:00:03 UTC

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #3352: ARTEMIS-2990 - alway be getBiased and only publish complete records a…

jbertram commented on a change in pull request #3352:
URL: https://github.com/apache/activemq-artemis/pull/3352#discussion_r527829815



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/AddressImpl.java
##########
@@ -84,6 +84,7 @@ public void addLinkedAddress(final Address address) {
       if (linkedAddresses == null) {
          linkedAddresses = PlatformDependent.hasUnsafe() ? new NonBlockingHashSet<>() : new ConcurrentHashSet<>();
       }
+      assert !linkedAddresses.contains(address);

Review comment:
       I'm not advocating one way or the other here, but aren't assertions disabled by the JVM by default and must be enabled using `-ea`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org