[GitHub] [drill] luocooong commented on pull request #2168: DRILL-7712: Fix issues after ZK upgrade

[GitBox <gi...@apache.org>]

luocooong commented on pull request #2168:
URL: https://github.com/apache/drill/pull/2168#issuecomment-791982190


   @eevanwong @vvysotskyi @cgivre All right. I think it means that there are errors before this upgrade : there may be no test condition for module of maprdb now. then run the mvn build with `mvn install -Dtests=cluster -Pmapr`, actually using the profile in following :
   ```xml
     <profiles>
       <profile>
         <id>mapr</id>
         <properties>
           <mapr.skip.tests>false</mapr.skip.tests>
         </properties>
       </profile>
       ...
   ```
   Is it possible to review the PR without maprdb (test)? Please create new JIRA about the following issues :
   ```
   java.lang.NoClassDefFoundError: org/apache/hadoop/hbase/protobuf/generated/MasterProtos$MasterService$BlockingInterface
   	at java.lang.Class.forName0(Native Method)
   	at java.lang.Class.forName(Class.java:264)
   	at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:294)
   	at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:237)
   	at org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:138)
   	at org.apache.drill.hbase.HBaseTestsSuite.initCluster(HBaseTestsSuite.java:120)
   ```
   and
   ```
   java.lang.NoClassDefFoundError: org/apache/hadoop/hbase/client/TableDescriptor
   	at com.mapr.drill.maprdb.tests.MaprDBTestsSuite.setupTests(MaprDBTestsSuite.java:66)
   Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.hbase.client.TableDescriptor
   	at com.mapr.drill.maprdb.tests.MaprDBTestsSuite.setupTests(MaprDBTestsSuite.java:66)
   ```
   So, We can't stop because of maprdb module, and speed up the review and merge is friendly for new contributor. thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org